CSF3: Remove path from autoTitle browser code
#17185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI ran the following commands for commit 6e98cec. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
It looks like some windows snapshot failures have snuck in while they haven't been running (see #17148), but I don't think there are any test failures related to this PR. |
shilman
changed the title
path from autoTitle browser codepath from autoTitle browser code
shilman
approved these changes
Jan 10, 2022
shilman
added
patch:yes
shilman
added a commit
that referenced
this pull request
Jan 20, 2022
CSF3: Remove `path` from autoTitle browser code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
In attempting to get autoTitle functionality working in the vite builder, I found that
pathwas being used in one of the modules which runs in the browser. This is a node.js module, and while webpack polyfills it, vite does not.See storybookjs/builder-vite#201 for context.
What I did
I've replaced the usage of
pathwith a simple join using/, and then performing a replacement of sets of one or more/with a single/.How to test
Existing tests seem to be robust enough to cover this change (there are tests for both trailing slashes and no trailing slashes).