Fix github workflow syntax to run unit-tests on push #17148
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Since d3bc320, the unit-tests github workflow has not been running on each merge to
next
, as it was supposed to.What I did
I think I had the syntax incorrect for determining whether the workflow was being triggered by a push (or alternatively by a pull_request). This instead uses the
github.event_name
as shown here: https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#example-using-contextsI also removed the
${{}}
syntax, since it is optional, as mentioned in https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#example-using-contexts:How to test
😬 I think the only real way to test this is to verify that the workflow does not happen when I open this PR, and then someone should add the
ci:matrix
label and verify it does run, then the real test comes if/when it is merged, to see if the workflow runs onnext
.