Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Don't fetch stories.json (either JSON or SSE) if we don't need it #16318

Merged
merged 4 commits into from
Oct 13, 2021
Merged

Core: Don't fetch stories.json (either JSON or SSE) if we don't need it #16318

merged 4 commits into from
Oct 13, 2021

Conversation

tmeasday
Copy link
Member

Issue: #16057

What I did

  • Don't connect to the SSE if CONFIG_MODE is not DEVELOPMENT
  • Don't fetch stories.json if FEATURES.storyStoreV7 is not set.

How to test

I tested manually in react-ts and cra-ts-essentials in the two modes.

@tmeasday tmeasday requested a review from shilman October 12, 2021 11:56
@nx-cloud
Copy link

nx-cloud bot commented Oct 12, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit 6d62f9f. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

shilman
shilman approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code is looking great. unit tests failing though?

shilman
shilman requested changes Oct 12, 2021
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failing unit tests

@shilman shilman changed the title Don't fetch stories.json (either JSON or SSE) if we don't need it. Core: Don't fetch stories.json (either JSON or SSE) if we don't need it Oct 13, 2021
@shilman shilman merged commit 89d2910 into next Oct 13, 2021
@shilman shilman deleted the 16057-no-stories-json-in-v6 branch October 13, 2021 01:06
@shilman shilman mentioned this pull request Oct 13, 2021
Closed
@shilman shilman added this to the 6.4 PRs milestone Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbf yannbf yannbf left review comments

@shilman shilman shilman approved these changes

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
6.4 PRs
Development

Successfully merging this pull request may close these issues.
3 participants
@tmeasday @shilman @yannbf