Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fetch stories.json from manager if we're not using it (compatibility mode) #16057

Closed
shilman opened this issue Sep 15, 2021 · 3 comments
Closed

Don't fetch stories.json from manager if we're not using it (compatibility mode) #16057

shilman opened this issue Sep 15, 2021 · 3 comments
Assignees
@tmeasday
Milestone
6.4 perf

Comments

@shilman
Copy link
Member

shilman commented Sep 15, 2021

No description provided.

@shilman shilman added this to the 6.4 perf milestone Sep 15, 2021
@shilman shilman mentioned this issue Sep 15, 2021
Closed
8 tasks
@ekeijl
Copy link

ekeijl commented Oct 10, 2021 •
edited
Loading

Is this a known issue when running SB 6.4.0-beta.7?

I just upgraded from alpha.23 to beta.7 and I started getting this 404 error on stories.json (not using composition, just running SB normally).
The error is hard to trace, but it seems to trigger from the StoryIndexClient module.

@shilman
Copy link
Member Author

shilman commented Oct 10, 2021

Yes and it's safe to ignore for now

@tmeasday tmeasday self-assigned this Oct 11, 2021
@tmeasday tmeasday mentioned this issue Oct 12, 2021
Merged
@shilman
Copy link
Member Author

shilman commented Oct 13, 2021

Crikey!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.4.0-beta.10 containing PR #16318 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmeasday tmeasday

Labels
None yet
Projects
None yet
Milestone
6.4 perf
Development

No branches or pull requests
3 participants
@tmeasday @ekeijl @shilman