-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Add Babel mode v7 #15928
Merged
Merged
Core: Add Babel mode v7 #15928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
added
configuration babel / webpack
maintenance
User-facing maintenance tasks
labels
Aug 27, 2021
Nx Cloud ReportCI ran the following commands for commit e3e0248. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
self-merging @tmeasday @ndelangen |
This was referenced Aug 31, 2021
Babel config incorrectly read (inaccurate docs + incorrect loading of Babel config functions)
#12745
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #14425 #2758 #12745 #15502 #12292
This PR overhauls Storybook's babel handling in preparation for v7.0.
Before:
babel
inmain.js
After (when
features.babelModeV7
flag is activated):.babelrc.json
)main.js webpackFinal
What I did
features.babelModeV7
sb init
Potential improvements
How to test
The easiest way to test this is to modify the
.babelrc
ofexamples/react-ts
, which hasbabelModeV7
enabled. You can:../../lib/cli/bin/index.js
babelModeV7
flagbabelModeV7
flag inexamples/cra-kitchen-sink
You can also do all of this with
BABEL_SHOW_CONFIG_FOR
enabled to see what's going on under the hood. But you can't actually run the Storybooks this way -- see the documentation.If your answer is yes to any of these, please make sure to include it in your PR.