-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Babel config incorrectly read (inaccurate docs + incorrect loading of Babel config functions) #12745
Comments
I investigated this further, and there appear to be two (fairly minor) problems. 1. The docs are inaccurate as to how Babel configs are picked up.
This isn't accurate. See this comment in the code. Suggested fix: Specify that only Babel configs nested in 2. Babel configs written using the config function API are not read properly.Babel supports dynamic configs by exporting a function taking a single argument Suggested fix: If |
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
The comment that explain the issue is now here: storybook/lib/core-common/src/utils/load-custom-babel-config.ts Lines 72 to 78 in cc0550c
|
Boo-yah!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.4.0-alpha.33 containing PR #15928 that references this issue. Upgrade today to the
Closing this issue. Please re-open if you think there's still more to do. |
Describe the bug
Same issue as #11218 is still present in
6.0.26
. Refiling a ticket based on the Stale bot's suggestion.To Reproduce
Same as #11218. In summary:
allowNamespaces
totrue
in the Typescript settingsI'm currently investigating why this particular Babel option seems to not be getting picked up by Storybook.
System
The text was updated successfully, but these errors were encountered: