fix: storybook & webpack 5 successfully build #12964
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScriptedAlchemy
requested review from
alexandrebodin,
alterx,
igor-dv,
kazupon,
thani-sh,
ndelangen,
shilman,
stijnkoopal,
thomasbertet,
tmeasday and
usulpro
as code owners
Closed
ScriptedAlchemy
changed the title
tnunes
reviewed
Oct 31, 2020
ScriptedAlchemy
requested review from
aaronmcadam,
CodeByAlex,
dangreenisrael,
jbovenschen,
leonrodenburg,
renaudtertrais,
saponifi3d,
theinterned and
z4o4z
as code owners
ScriptedAlchemy
force-pushed
the
tech/webpack5
branch
3 times, most recently
from
c77ebe4 to
176be47
Compare
ScriptedAlchemy
force-pushed
the
tech/webpack5
branch
from
176be47 to
8ba5e09
Compare
ScriptedAlchemy
force-pushed
the
tech/webpack5
branch
from
8ba5e09 to
e3dd28f
Compare
3 tasks
# Conflicts: # addons/a11y/package.json # addons/actions/package.json # addons/backgrounds/package.json # addons/controls/package.json # addons/cssresources/package.json # addons/design-assets/package.json # addons/docs/package.json # addons/essentials/package.json # addons/events/package.json # addons/google-analytics/package.json # addons/graphql/package.json # addons/jest/package.json # addons/knobs/package.json # addons/links/package.json # addons/queryparams/package.json # addons/storyshots/storyshots-core/package.json # addons/storyshots/storyshots-puppeteer/package.json # addons/storysource/package.json # addons/toolbars/package.json # addons/viewport/package.json # app/angular/package.json # app/aurelia/package.json # app/ember/package.json # app/ember/src/server/framework-preset-babel-ember.ts # app/html/package.json # app/marionette/package.json # app/marko/package.json # app/mithril/package.json # app/preact/package.json # app/rax/package.json # app/react/package.json # app/riot/package.json # app/server/package.json # app/svelte/package.json # app/vue/package.json # app/web-components/package.json # dev-kits/addon-decorator/package.json # dev-kits/addon-parameter/package.json # dev-kits/addon-roundtrip/package.json # docs/package.json # examples/angular-cli/package.json # examples/aurelia-kitchen-sink/package.json # examples/cra-ts-essentials/package.json # examples/cra-ts-kitchen-sink/package.json # examples/dev-kits/package.json # examples/marko-cli/package.json # examples/mithril-kitchen-sink/package.json # examples/official-storybook/package.json # examples/preact-kitchen-sink/package.json # examples/rax-kitchen-sink/package.json # examples/react-ts/package.json # examples/riot-kitchen-sink/package.json # examples/server-kitchen-sink/package.json # examples/vue-cli/package.json # examples/vue-kitchen-sink/package.json # examples/web-components-kitchen-sink/package.json # lib/addons/package.json # lib/api/package.json # lib/api/src/version.ts # lib/channel-postmessage/package.json # lib/channel-websocket/package.json # lib/channels/package.json # lib/cli/package.json # lib/cli/test/fixtures/react_static_next/package.json # lib/cli/test/fixtures/sfc_vue/package.json # lib/codemod/package.json # lib/components/package.json # lib/core/package.json # lib/core/src/server/preview/iframe-webpack.config.js # lib/source-loader/package.json # lib/theming/package.json # lib/ui/package.json # package.json # yarn.lock
|
@ScriptedAlchemy I tried to merge next into this branch to help you out, but stumbled on quite a few merge conflicts. I tried to resolve them as best as I can. Maybe this help, maybe not: https://github.com/storybookjs/storybook/tree/pr/ScriptedAlchemy/12964-2 |
|
Any updates on this? |
3 tasks
|
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
|
Webpack 5 support is available in 6.2 Prerelease version now! See the testing instructions at https://gist.github.com/shilman/8856ea1786dcd247139b47b270912324 and if you have any issues, please open a new issue about it so we can take a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Build didn't work
What I did
How to test
i ran one example and it seems to build. needs more testing from those who know storybook
If your answer is yes to any of these, please make sure to include it in your PR.
there are many references to webpack 4 in here. If I do a global search, everything needs to updated to webpack 5. You can use syncpack to sync it every