Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(ReactComponentLibrary): Upgrade to WebPack 5 #1614

Closed
wants to merge 2 commits into from

Conversation

m7kvqbe1
Copy link
Collaborator

@m7kvqbe1 m7kvqbe1 commented Nov 2, 2020

Related issue

Closes #1478

Overview

Upgrade to WebPack 5 and build optimisations.

Work carried out

  • Upgrade to WebPack 5
  • Optimise build for consumers
  • Storybook WebPack 5 upgrade

Developer notes

storybookjs/storybook#12964

@m7kvqbe1 m7kvqbe1 self-assigned this Nov 2, 2020
@m7kvqbe1 m7kvqbe1 added the Status: Blocked Unable to progress currently due to internal/external blocker label Nov 2, 2020
@m7kvqbe1
Copy link
Collaborator Author

There is another PR now for storybook - the last one appears to be stale and abandoned.

Unfortunately it looks like this is also now going stale: storybookjs/storybook#13392

@m7kvqbe1
Copy link
Collaborator Author

m7kvqbe1 commented Feb 9, 2021

Alpha due for release imminently: storybookjs/storybook#13392 (comment)

@m7kvqbe1
Copy link
Collaborator Author

@m7kvqbe1 m7kvqbe1 removed the Status: Blocked Unable to progress currently due to internal/external blocker label Feb 24, 2021
@Royal-Navy Royal-Navy deleted a comment from codeclimate bot Mar 24, 2021
@elglup elglup added Type: Dependencies Issues that relate to a dependency Size: Medium Assessed as medium task and removed dependencies labels Jun 4, 2021
@m7kvqbe1 m7kvqbe1 force-pushed the feat/webpack-optimizations branch from 52e9367 to 9f2a671 Compare June 7, 2021 20:56
@m7kvqbe1 m7kvqbe1 changed the title [WIP] build(ReactComponentLibrary): Upgrade to WebPack 5 build(ReactComponentLibrary): Upgrade to WebPack 5 Jun 7, 2021
@m7kvqbe1 m7kvqbe1 marked this pull request as ready for review June 7, 2021 21:00
@m7kvqbe1 m7kvqbe1 requested a review from thyhjwb6 as a code owner June 7, 2021 21:00
@m7kvqbe1 m7kvqbe1 force-pushed the feat/webpack-optimizations branch 2 times, most recently from e4305c2 to 5f9a46d Compare June 7, 2021 21:22
@m7kvqbe1 m7kvqbe1 force-pushed the feat/webpack-optimizations branch from 5f9a46d to 77e1e7f Compare June 10, 2021 10:24
@m7kvqbe1 m7kvqbe1 force-pushed the feat/webpack-optimizations branch from 77e1e7f to 349b9f9 Compare June 10, 2021 10:25
@m7kvqbe1
Copy link
Collaborator Author

When upgraded Storybook no longer generates interface documentation from DocBlocks correctly.

Marking as blocked again and waiting for issue to be sorted upstream.

@m7kvqbe1 m7kvqbe1 added the Status: Blocked Unable to progress currently due to internal/external blocker label Jun 10, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@m7kvqbe1
Copy link
Collaborator Author

Closing this ancient PR in favour of @jpveooys recent changes.

@m7kvqbe1 m7kvqbe1 closed this Nov 16, 2021
@markhigham markhigham deleted the feat/webpack-optimizations branch April 11, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: react-component-library Package/code type Size: Medium Assessed as medium task Status: Blocked Unable to progress currently due to internal/external blocker Type: Dependencies Issues that relate to a dependency Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review webpack bundling strategy for react-component-library (performance & best practices)
3 participants