React: Apply React 17 and CRA4 fixes to master #12925
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
requested review from
aaronmcadam,
alexandrebodin,
alterx,
CodeByAlex,
dangreenisrael,
danielduan,
igor-dv,
jbovenschen,
kazupon,
leonrodenburg,
thani-sh,
ndelangen,
renaudtertrais,
saponifi3d,
stijnkoopal,
theinterned,
thomasbertet,
tmeasday,
usulpro and
z4o4z
as code owners
shilman
changed the title
This reverts commit 5df5380.
abillingsley
added a commit
to developertown/frontend
that referenced
this pull request
Oct 29, 2020
ndelangen
approved these changes
Nov 2, 2020
Hypnosphi
reviewed
Nov 2, 2020
| @@ -53,8 +53,8 @@ | |||
| "devDependencies": { | |||
| "@testing-library/react": "^10.0.4", | |||
| "@types/webpack-env": "^1.15.2", | |||
| "react": "^16.13.1", | |||
| "react-dom": "^16.13.1" | |||
| "react": "^16.8.3 || ^17.0.0", | |||
There was a problem hiding this comment.
There's probably no point of using || in devDependencies
|
superceded by #12972 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #12408 #12881 #11904
What I did
Rollup of #12899 and #12908 applied to
masterHow to test
CI tests