React: Support JSX react transform introduced in 16.14.0 #12899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tooppaaa
reviewed
Oct 24, 2020
Test: jsx runtime
…ookjs/storybook into 12881-jsx-transform-react
arcanis
reviewed
Oct 26, 2020
|
|
||
| export async function babelDefault(config: TransformOptions) { | ||
| const presetReactOptions = hasJsxRuntime() ? { runtime: 'automatic' } : {}; |
There was a problem hiding this comment.
Wouldn't a better approach be to use path.dirname(config.filename) to get the directory for the file being transformed, pass that to hasJsxRuntime, and use it as the paths value for the require.resolve lookup (rather than poking into an arbitrary nm folder)?
There was a problem hiding this comment.
shilman
added a commit
that referenced
this pull request
Oct 27, 2020
This was referenced Oct 27, 2020
Xerkus
reviewed
Feb 6, 2021
Comment on lines
+26
to
+32
| const context = storybookReactDirName.includes('node_modules') | ||
| ? path.join(storybookReactDirName, '../../') // Real life case, already in node_modules | ||
| : path.join(storybookReactDirName, '../../node_modules'); // SB Monorepo | ||
|
|
||
| const hasJsxRuntime = () => { | ||
| try { | ||
| require.resolve('react/jsx-runtime', { paths: [context] }); |
There was a problem hiding this comment.
Why does it try to use node_modules folder for lookup? It can't work with yarn 2 pnp.
CRA uses require.resolve('react/jsx-runtime'); for the detection:
https://github.com/facebook/create-react-app/blob/282c03f9525fdf8061ffa1ec50dce89296d916bd/packages/react-scripts/config/webpack.config.js#L79-L85
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #12881
What I did
Hack to add the
automaticruntime per the NextJS implementationHow to test
Added it by hand in a copy of
examples/react-ts's node_modules 🙈==> Unfortunately it's getting Storybook's React version, not the user's version...