Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Disable Docs DLL by default #12874

Merged
merged 1 commit into from
Oct 23, 2020
Merged

Core: Disable Docs DLL by default #12874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions addons/docs/src/frameworks/common/preset.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ function createBabelOptions({ babelOptions, mdxBabelOptions, configureJSX }: Bab
}

export const webpackDlls = (dlls: string[], options: any) => {
return options.dll ? [...dlls, './sb_dll/storybook_docs_dll.js'] : [];
return options.docsDll ? [...dlls, './sb_dll/storybook_docs_dll.js'] : [];
};

export function webpack(webpackConfig: any = {}, options: any = {}) {
Expand Down Expand Up @@ -143,7 +143,7 @@ export function webpack(webpackConfig: any = {}, options: any = {}) {
},
};

if (options.dll) {
if (options.docsDll) {
result.plugins.push(
new DllReferencePlugin({
context,
Expand Down
6 changes: 4 additions & 2 deletions docs/api/cli-options.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ Usage: start-storybook [options]
| --smoke-test | Exit after successful start | `start-storybook --smoke-test` |
| --ci | CI mode (skip interactive prompts, don't open browser) | `start-storybook --ci` |
| --quiet | Suppress verbose build output | `start-storybook --quiet` |
| --no-dll | Do not use dll reference | `start-storybook --no-dll` |
| --no-dll | Do not use UI dll reference | `start-storybook --no-dll` |
| --docs-dll | Use the Docs dll reference (legacy) | `start-storybook --docs-dll` |
| --debug-webpack | Display final webpack configurations for debugging purposes | `start-storybook --debug-webpack` |
| --docs | Starts Storybook in documentation mode. Learn more about it in [here](../writing-docs/build-documentation.md#preview-storybooks-documentation) | `start-storybook --docs` |

Expand All @@ -47,6 +48,7 @@ Usage: build-storybook [options]
| -w, --watch | Enables watch mode | `build-storybook -w` |
| --loglevel [level] | Controls level of logging during build. Can be one of: [silly, verbose, info (default), warn, error, silent] | `build-storybook --loglevel warn` |
| --quiet | Suppress verbose build output | `build-storybook --quiet` |
| --no-dll | Do not use dll reference | `build-storybook --no-dll` |
| --no-dll | Do not use UI dll reference | `build-storybook --no-dll` |
| --docs-dll | Use Docs dll reference (legacy) | `build-storybook --docs-dll` |
| --debug-webpack | Display final webpack configurations for debugging purposes | `build-storybook --debug-webpack` |
| --docs | Builds Storybook in documentation mode. Learn more about it in [here](../writing-docs/build-documentation.md#publish-storybooks-documentation)) | `build-storybook --docs` |
3 changes: 2 additions & 1 deletion lib/core/src/server/cli/dev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ async function getCLI(packageJson) {
'Suppress automatic redirects to the release notes after upgrading',
true
)
.option('--no-dll', 'Do not use dll reference')
.option('--no-dll', 'Do not use UI dll reference')
.option('--docs-dll', 'Use Docs dll reference (legacy)')
.option('--debug-webpack', 'Display final webpack configurations for debugging purposes')
.option(
'--preview-url [string]',
Expand Down
3 changes: 2 additions & 1 deletion lib/core/src/server/cli/prod.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ function getCLI(packageJson) {
.option('-w, --watch', 'Enable watch mode')
.option('--quiet', 'Suppress verbose build output')
.option('--loglevel [level]', 'Control level of logging during build')
.option('--no-dll', 'Do not use dll reference')
.option('--no-dll', 'Do not use UI dll reference (legacy)')
.option('--docs-dll', 'Use Docs dll reference')
.option('--debug-webpack', 'Display final webpack configurations for debugging purposes')
.option(
'--preview-url [string]',
Expand Down