Core: Disable Docs DLL by default #12874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
added
bug
patch:yes
shilman
requested review from
alterx,
igor-dv,
ndelangen and
tmeasday
as code owners
ndelangen
approved these changes
Oct 23, 2020
This was referenced Oct 23, 2020
|
👏 well played |
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Oct 23, 2020
Core: Disable Docs DLL by default
This was referenced Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #12408 #10982 #12016
What I did
Storybook 6.0 has two Webpack DLLs: the UI DLL that runs in the manager, the Docs DLL that runs in the preview with user code. This PR disables the Docs DLL by default because it's causing lots of version conflicts, e.g. React 17, core-js, etc. in exchange for some performance improvements.
This PR disables the docs DLL by default since the current out of box experience for Storybook is broken now that React 17 has landed.
There are a few implications:
This is technically a breaking change, but if you want to restore the old behavior you can run
start-storybookorbuild-storybookwith the--docs-dllflag to restore the old behavior.Soon in 6.1 we will attempt to remove all DLLs entirely #12637 and will be working to fix the corresponding performance issues in other ways.
How to test
TBD