-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backgrounds addons do not show by default #5818
Comments
I got it to work but only by doing the following stories.add('Basic', () => <Card style={styles}>I'm a simple card</Card>, {
notes: {
markdown
},
backgrounds: [
{ name: 'white', value: 'white', default: true },
{ name: 'twitter', value: '#00aced' },
{ name: 'facebook', value: '#3b5998' }
]
}); |
It seems like this can also be done for the viewport with
all current documented ways are incorrect (i think) |
@hipstersmoothie Great catch, we should fix this before launch. Your repo also revealed another good one: #5822 |
Didn't change any supported behaviour, but this should help with users migrating. #5818
Yippee!! I just released https://github.com/storybooks/storybook/releases/tag/v5.0.0-rc.10 containing PR #5828 that references this issue. Upgrade today to try it out! Because it's a pre-release you can find it on the Closing this issue. Please re-open if you think there's still more to do. |
@shilman @hipstersmoothie - not certain if this is related, but currently using the viewport addon obscures the very useful background grid, let me know if this should be a separate issue. |
UPDATE:
This issue describes problems with both
addon-backgrounds
andaddon-viewports
. The viewports bug is a duplicate to #5757, so I'm reappropriating this issue to backgrounds since it's a separate work item. --@shilmanDescribe the bug
addon-backgrounds and addon-viewport do not display in any way
To Reproduce
Steps to reproduce the behavior:
yarn && yarn storybook
Expected behavior
Should display
Screenshots
System:
The text was updated successfully, but these errors were encountered: