Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Babel errors swallowed in v5 UI #5822

Closed
shilman opened this issue Mar 3, 2019 · 3 comments
Closed

Babel errors swallowed in v5 UI #5822

shilman opened this issue Mar 3, 2019 · 3 comments
Assignees
@ndelangen
Labels
bug configuration babel / webpack has workaround
Milestone
5.1.x

Comments

@shilman
Copy link
Member

shilman commented Mar 3, 2019

Describe the bug

When my JSX has a syntax error, v5 does not display the error in the UI.

For instance in this example repo https://github.com/hipstersmoothie/story-bug there is a bug:

github_desktop

In v4, error displays in the terminal, browser console, AND UI:

storybook

In v5, error displays only in the terminal and browser console:

storybook
@shilman shilman added this to the v5.0.0 milestone Mar 3, 2019
@shilman shilman mentioned this issue Mar 3, 2019
Closed
@shilman shilman modified the milestones: v5.0.0, 5.0.x Mar 5, 2019
@stale stale bot added the inactive label Mar 26, 2019
@shilman shilman removed the inactive label Mar 26, 2019
@stale stale bot added the inactive label Apr 16, 2019
@shilman shilman removed the inactive label Apr 16, 2019
@stale stale bot added the inactive label May 8, 2019
@thegiantbeast-csm
Copy link

@shilman how does the workaround work?

Because I didn't had any success following the comments on #5818. Thanks!

@stale stale bot removed the inactive label May 27, 2019
@shilman
Copy link
Member Author

shilman commented May 27, 2019

The workaround is to open the dev tools and see the console output there

@ndelangen ndelangen self-assigned this Jun 4, 2019
@storybookjs storybookjs deleted a comment from stale bot Jun 4, 2019
@storybookjs storybookjs deleted a comment from stale bot Jun 4, 2019
@storybookjs storybookjs deleted a comment from stale bot Jun 4, 2019
@ndelangen ndelangen mentioned this issue Jun 4, 2019
Merged
@shilman shilman modified the milestones: 5.0.x, 5.1.x Jun 5, 2019
@shilman
Copy link
Member Author

shilman commented Jun 25, 2019

Hurrah!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.2.0-alpha.30 containing PR #6972 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndelangen ndelangen

Labels
bug configuration babel / webpack has workaround
Projects
None yet
Milestone
5.1.x
Development

No branches or pull requests
3 participants
@shilman @ndelangen @thegiantbeast-csm