Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade package.json #58

Merged
merged 2 commits into from
Mar 31, 2023
Merged

Upgrade package.json #58

merged 2 commits into from
Mar 31, 2023

Conversation

JReinhold
Copy link
Contributor

@JReinhold JReinhold commented Mar 31, 2023 •
edited by dannyhw
Loading

This PR does a few things to the package.json. I don't know much about this addon, but I did ensure that the build and build-storybook script still worked, and that all the stories after start worked as expected.

  1. Removes the unused peer dependencies on Storybook. I did a project wide search for each of them, and none of them were used anywhere. Some of them are deprecated in v7 like @storybook/addons so it would be nice to clean them up. But maybe I'm missing some aspect here?
  2. Widen the devDeps on SB pacakges, so it supports the released 7.0.0.
  3. Fix the start script by removing the removed --no-manager-cache flag.

storybook

📦 Published PR as canary version: 0.0.20--canary.58.da0bae1.0

✨ Test out this PR locally via:

npm install @storybook/[email protected]
# or 
yarn add @storybook/[email protected]

@JReinhold JReinhold requested a review from dannyhw March 31, 2023 19:16
@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎

🚨 Potential security issues found in this pull request. To accept the risk, merge this PR and you will not be notified again.

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

⚠️ Shell access

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

Package Module Location Source
@auto-it/[email protected] (upgraded) child_process dist/tests/auto-make-changelog.test.js package.json via [email protected]
@auto-it/[email protected] (upgraded) child_process dist/tests/auto.test.js package.json via [email protected]
@auto-it/[email protected] (upgraded) child_process dist/tests/get-current-branch.test.js package.json via [email protected]
@auto-it/[email protected] (upgraded) child_process dist/tests/get-remote.test.js package.json via [email protected]
@auto-it/[email protected] (upgraded) child_process dist/tests/release.test.js package.json via [email protected]
@auto-it/[email protected] (upgraded) child_process dist/auto.js package.json via [email protected]
@auto-it/[email protected] (upgraded) child_process dist/release.js package.json via [email protected]
@auto-it/[email protected] (upgraded) child_process dist/utils/tests/load-plugin.test.js package.json via [email protected]
@auto-it/[email protected] (upgraded) child_process dist/utils/tests/verify-auth.test.js package.json via [email protected]
@auto-it/[email protected] (upgraded) child_process dist/utils/exec-promise.js package.json via [email protected]
@auto-it/[email protected] (upgraded) child_process dist/utils/get-current-branch.js package.json via [email protected]
@auto-it/[email protected] (upgraded) child_process dist/utils/load-plugins.js package.json via [email protected]
@auto-it/[email protected] (upgraded) child_process dist/utils/verify-auth.js package.json via [email protected]
@auto-it/[email protected] (upgraded) child_process dist/index.js package.json via [email protected]
@aw-web-design/[email protected] (added) child_process src/detect-linux.js package.json via [email protected]
@aw-web-design/[email protected] (added) child_process src/detect-windows.js package.json via [email protected]
@aw-web-design/[email protected] (added) child_process src/detect-windows10.js package.json via [email protected]
@expo/[email protected] (added) child_process build/src/run/ios/XcodeBuild.js package.json via [email protected]
@expo/[email protected] (added) child_process build/src/start/doctor/apple/XcodePrerequisite.js package.json via [email protected]
@expo/[email protected] (added) child_process build/src/start/doctor/apple/XcrunPrerequisite.js package.json via [email protected]
@expo/[email protected] (added) child_process build/src/start/platforms/android/activateWindow.js package.json via [email protected]
@expo/[email protected] (added) child_process build/src/start/platforms/android/ADBServer.js package.json via [email protected]
@expo/[email protected] (added) child_process build/src/start/platforms/ios/simctlLogging.js package.json via [email protected]
@expo/[email protected] (added) child_process build/src/utils/getRunningProcess.js package.json via [email protected]
@expo/[email protected] (added) child_process build/LaunchBrowserImplMacOS.js package.json via [email protected]
@expo/[email protected] (added) child_process dist/platforms/shared.js package.json via [email protected]
@expo/[email protected] (added) child_process dist/utils.js package.json via [email protected]
@expo/[email protected] (added) child_process build/utils/yarn.js package.json via [email protected]
@react-native-community/[email protected] (upgraded) child_process build/index.js package.json via [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
@react-native-community/[email protected] (upgraded) child_process build/tools/yarn.js package.json via [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
@react-native-community/[email protected] (upgraded) child_process build/commands/buildIOS/buildProject.js package.json via [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
@react-native-community/[email protected] (upgraded) child_process build/commands/runIOS/index.js package.json via [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
@react-native-community/[email protected] (upgraded) child_process build/tools/getDestinationSimulator.js package.json via [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
[email protected] (added) child_process lib/index.js package.json via @storybook/[email protected], [email protected], [email protected]
[email protected] (upgraded) child_process dist/index.js package.json via [email protected]
[email protected] (added) child_process lib/command-exists.js package.json via [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
[email protected] (added) child_process lib/command-exists.js package.json via [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
[email protected] (upgraded) child_process index.js package.json via [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
[email protected] (upgraded) child_process index.js package.json via @storybook/[email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
[email protected] (upgraded) child_process index.js package.json via [email protected]
[email protected] (upgraded) child_process lib/command.js package.json via [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
[email protected] (added) child_process index.js package.json via @react-native-community/[email protected], @storybook/[email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
[email protected] (added) child_process dist/envinfo.js package.json via [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
[email protected] (upgraded) child_process install.js package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], [email protected]
[email protected] (upgraded) child_process lib/main.js package.json via @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], [email protected]
[email protected] (added) child_process index.js package.json via [email protected]
[email protected] (added) child_process index.js package.json via [email protected], [email protected], [email protected]
[email protected] (added) child_process index.js package.json via @storybook/[email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
[email protected] (added) child_process dist/gitlog.cjs.development.js package.json via [email protected]
[email protected] (added) child_process dist/gitlog.cjs.production.min.js package.json via [email protected]
[email protected] (added) child_process dist/gitlog.esm.js package.json via [email protected]
[email protected] (added) child_process jake-v10.8.5/jakefile.js package.json via [email protected]
[email protected] (added) child_process jake-v10.8.5/lib/package_task.js package.json via [email protected]
[email protected] (added) child_process jake-v10.8.5/lib/publish_task.js package.json via [email protected]
[email protected] (added) child_process jake-v10.8.5/lib/utils/index.js package.json via [email protected]
[email protected] (added) child_process jake-v10.8.5/test/integration/concurrent.js package.json via [email protected]
[email protected] (added) child_process jake-v10.8.5/test/integration/file_task.js package.json via [email protected]
[email protected] (added) child_process jake-v10.8.5/test/integration/file.js package.json via [email protected]
[email protected] (added) child_process jake-v10.8.5/test/integration/helpers.js package.json via [email protected]
[email protected] (added) child_process jake-v10.8.5/test/integration/jakelib/rule.jake.js package.json via [email protected]
[email protected] (added) child_process jake-v10.8.5/test/integration/publish_task.js package.json via [email protected]
[email protected] (added) child_process jake-v10.8.5/test/integration/rule.js package.json via [email protected]
[email protected] (added) child_process jake-v10.8.5/test/integration/selfdep.js package.json via [email protected]
[email protected] (added) child_process jake-v10.8.5/test/integration/task_base.js package.json via [email protected]
[email protected] (added) child_process jake-v10.8.5/test/integration/task_base.js package.json via [email protected]
[email protected] (upgraded) child_process build/crawlers/node.js package.json via [email protected], [email protected]
[email protected] (upgraded) child_process build/lib/isWatchmanInstalled.js package.json via [email protected], [email protected]
[email protected] (upgraded) child_process build/workers/ChildProcessWorker.js package.json via @storybook/[email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
[email protected] (upgraded) child_process dist/Runner.js package.json via [email protected]
[email protected] (upgraded) child_process src/Runner.js package.json via [email protected]
[email protected] (added) child_process build/android/adb.js package.json via [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
[email protected] (added) child_process build/ios/simulator.js package.json via [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
[email protected] (upgraded) child_process src/crawlers/node.js package.json via [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
[email protected] (upgraded) child_process src/lib/checkWatchmanCapabilities.js package.json via [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
[email protected] (upgraded) child_process index.js package.json via [email protected]
[email protected] (added) child_process osenv.js package.json via [email protected]
[email protected] (added) child_process index.js package.json via [email protected]
[email protected] (added) child_process lib/resolvers.js package.json via [email protected], [email protected]
[email protected] (added) child_process src/exec-child.js package.json via [email protected]
[email protected] (added) child_process src/exec.js package.json via [email protected]
[email protected] (added) child_process index.js package.json via [email protected]
[email protected] (added) child_process test-concurrent.js package.json via [email protected]
[email protected] (added) child_process test.js package.json via [email protected]
[email protected] (added) child_process index.js package.json via [email protected]
[email protected] (added) child_process test-concurrent.js package.json via [email protected]
[email protected] (added) child_process test.js package.json via [email protected]
[email protected] (added) child_process index.js package.json via [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
[email protected] (added) child_process test-concurrent.js package.json via [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
[email protected] (added) child_process [test.js](https://socket.dev/npm/package/sudo-prompt/f

dannyhw
dannyhw reviewed Mar 31, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@dannyhw
Copy link
Member

dannyhw commented Mar 31, 2023

Thanks @JReinhold 🙏

dannyhw
dannyhw approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@dannyhw dannyhw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, assuming the chromatic build passes this should be fine to merge.

Thanks 🙇

@JReinhold
Copy link
Contributor Author

Two of the stories seems to be 1px higher than the baseline in Chromatic? 😵‍💫

@dannyhw dannyhw merged commit fed1768 into next Mar 31, 2023
@github-actions github-actions bot mentioned this pull request Mar 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannyhw dannyhw dannyhw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JReinhold @dannyhw