Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storybook v7 #53

Merged
merged 6 commits into from
Mar 31, 2023
Merged

storybook v7 #53

merged 6 commits into from
Mar 31, 2023

Conversation

dannyhw
Copy link
Member

@dannyhw dannyhw commented Feb 10, 2023

This will be a PR that stays open until v7 is stable at which point we can merge it to release a v7 version of the addon.
thanks to @natsuki-ornikar and @arnaudmanaranche for their help on this (#52)

Version

Published prerelease version: v0.0.20-next.3

Changelog

🐛 Bug Fix

⚠️ Pushed to next

Authors: 5

📦 Published PR as canary version: 0.0.20--canary.53.8704aea.0

✨ Test out this PR locally via:

npm install @storybook/[email protected]
# or 
yarn add @storybook/[email protected]

* chore(migration): migrate from storybook v6 to v7

* fix: format mdx file

* fix: add missing babel plugin

---------

authored-by: Arnaud Manaranche <[email protected]>
@socket-security
Copy link

socket-security bot commented Feb 10, 2023

New dependency changes detected. Learn more about Socket for GitHub ↗︎


🚨 Potential security issues found in this pull request. To accept the risk, merge this PR and you will not be notified again.

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

😵‍💫 Bin script confusion

This package has multiple bin scripts with the same name. This can cause non-deterministic behavior when installing or could be a sign of a supply chain attack

Consider removing one of the conflicting packages. Packages should only export bin scripts with their name

Package Bin script Source
[email protected] (upgraded) uglifyjs
[email protected] (upgraded) jest package.json
[email protected] (upgraded) jest package.json via [email protected]
⚠️ Shell access

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

Package Module Location Source
@auto-it/[email protected] (upgraded) child_process dist/tests/auto-make-changelog.test.js package.json via [email protected]
@auto-it/[email protected] (upgraded) child_process dist/tests/auto.test.js package.json via [email protected]
@auto-it/[email protected] (upgraded) child_process dist/tests/get-current-branch.test.js package.json via [email protected]
@auto-it/[email protected] (upgraded) child_process dist/tests/get-remote.test.js package.json via [email protected]
@auto-it/[email protected] (upgraded) child_process dist/tests/release.test.js package.json via [email protected]
@auto-it/[email protected] (upgraded) child_process dist/auto.js package.json via [email protected]
@auto-it/[email protected] (upgraded) child_process dist/release.js package.json via [email protected]
@auto-it/[email protected] (upgraded) child_process dist/utils/tests/load-plugin.test.js package.json via [email protected]
@auto-it/[email protected] (upgraded) child_process dist/utils/tests/verify-auth.test.js package.json via [email protected]
@auto-it/[email protected] (upgraded) child_process dist/utils/exec-promise.js package.json via [email protected]
@auto-it/[email protected] (upgraded) child_process dist/utils/get-current-branch.js package.json via [email protected]
@auto-it/[email protected] (upgraded) child_process dist/utils/load-plugins.js package.json via [email protected]
@auto-it/[email protected] (upgraded) child_process dist/utils/verify-auth.js package.json via [email protected]
@auto-it/[email protected] (upgraded) child_process dist/index.js package.json via [email protected]
@expo/[email protected] (added) child_process build/src/run/ios/XcodeBuild.js package.json via [email protected]
@expo/[email protected] (added) child_process build/src/start/doctor/apple/XcodePrerequisite.js package.json via [email protected]
@expo/[email protected] (added) child_process build/src/start/doctor/apple/XcrunPrerequisite.js package.json via [email protected]
@expo/[email protected] (added) child_process build/src/start/platforms/android/activateWindow.js package.json via [email protected]
@expo/[email protected] (added) child_process build/src/start/platforms/android/ADBServer.js package.json via [email protected]
@expo/[email protected] (added) child_process build/src/start/platforms/ios/simctlLogging.js package.json via [email protected]
@expo/[email protected] (added) child_process build/src/utils/getRunningProcess.js package.json via [email protected]
@expo/[email protected] (added) child_process build/LaunchBrowserImplMacOS.js package.json via [email protected]
@expo/[email protected] (added) child_process dist/platforms/shared.js package.json via [email protected]
@expo/[email protected] (added) child_process dist/utils.js package.json via [email protected]
@expo/[email protected] (added) child_process build/utils/yarn.js package.json via [email protected]
@react-native-community/[email protected] (upgraded) child_process build/index.js package.json via [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
@react-native-community/[email protected] (upgraded) child_process build/tools/yarn.js package.json via [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
@react-native-community/[email protected] (upgraded) child_process build/commands/buildIOS/buildProject.js package.json via [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
@react-native-community/[email protected] (upgraded) child_process build/commands/runIOS/index.js package.json via [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
@react-native-community/[email protected] (upgraded) child_process build/tools/getDestinationSimulator.js package.json via [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
[email protected] (added) child_process lib/index.js package.json via @storybook/[email protected], [email protected], [email protected]
[email protected] (upgraded) child_process dist/index.js package.json via [email protected]
[email protected] (added) child_process lib/command-exists.js package.json via [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
[email protected] (added) child_process lib/command-exists.js package.json via [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
[email protected] (upgraded) child_process index.js package.json via [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
[email protected] (upgraded) child_process index.js package.json via @storybook/[email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
[email protected] (upgraded) child_process index.js package.json via [email protected]
[email protected] (upgraded) child_process lib/command.js package.json via [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
[email protected] (added) child_process index.js package.json via @react-native-community/[email protected], @storybook/[email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
[email protected] (added) child_process dist/envinfo.js package.json via [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
[email protected] (added) child_process index.js package.json via [email protected]
[email protected] (added) child_process index.js package.json via [email protected], [email protected], [email protected]
[email protected] (upgraded) child_process index.js package.json via @storybook/[email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
[email protected] (added) child_process dist/gitlog.cjs.development.js package.json via [email protected]
[email protected] (added) child_process dist/gitlog.cjs.production.min.js package.json via [email protected]
[email protected] (added) child_process dist/gitlog.esm.js package.json via [email protected]
[email protected] (upgraded) child_process build/crawlers/node.js package.json via [email protected], [email protected]
[email protected] (upgraded) child_process build/lib/isWatchmanInstalled.js package.json via [email protected], [email protected]
[email protected] (upgraded) child_process build/workers/ChildProcessWorker.js package.json via @storybook/[email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
[email protected] (upgraded) child_process dist/Runner.js package.json via [email protected]
[email protected] (upgraded) child_process src/Runner.js package.json via [email protected]
[email protected] (added) child_process build/android/adb.js package.json via [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
[email protected] (added) child_process build/ios/simulator.js package.json via [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
[email protected] (upgraded) child_process src/crawlers/node.js package.json via [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
[email protected] (upgraded) child_process src/lib/checkWatchmanCapabilities.js package.json via [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
[email protected] (upgraded) child_process index.js package.json via [email protected]
[email protected] (added) child_process osenv.js package.json via [email protected]
[email protected] (added) child_process index.js package.json via [email protected]
[email protected] (added) child_process lib/resolvers.js package.json via [email protected], [email protected]
[email protected] (added) child_process index.js package.json via [email protected]
[email protected] (added) child_process test-concurrent.js package.json via [email protected]
[email protected] (added) child_process test.js package.json via [email protected]
[email protected] (added) child_process index.js package.json via [email protected]
[email protected] (added) child_process test-concurrent.js package.json via [email protected]
[email protected] (added) child_process test.js package.json via [email protected]
[email protected] (added) child_process index.js package.json via [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
[email protected] (added) child_process test-concurrent.js package.json via [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
[email protected] (added) child_process test.js package.json via [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
[email protected] (added) child_process examples/grepcount.js package.json via [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
[email protected] (added) child_process examples/pdfcreator.js package.json via [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
[email protected] (added) child_process index.js package.json via [email protected]
[email protected] (added) child_process dist/child/spawn-child.js package.json via [email protected], [email protected]
[email protected] (upgraded) child_process lib/tsserver.js package.json via @react-native-community/[email protected], @storybook/[email protected], [email protected], [email protected], [email protected], [email protected]
[email protected] (upgraded) child_process lib/tsserver.js package.json via @react-native-community/[email protected], @storybook/[email protected], [email protected], [email protected], [email protected], [email protected]
[email protected] (upgraded) child_process lib/typingsInstaller.js package.json via @react-native-community/[email protected], @storybook/[email protected], [email protected], [email protected], [email protected], [email protected]
[email protected] (added) child_process check-npm-version.js package.json via @babel/[email protected], @babel/[email protected], @babel/[email protected], @babel/[email protected], @babel/[email protected], @react-native-community/[email protected], @storybook/[email protected], @storybook/[email protected], @storybook/[email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [[email protected]](https://socket.dev/npm/package/react-nativ

@JReinhold
Copy link
Contributor

@dannyhw this looks good, will you take care of merging it when 7.0 goes stable? I guess the only change needed is changing the dependencies to not point at rc anymore, but you obviously can't do that before it's released.

I also see a dependency on @storybook/manager-webpack5 which isn't relevant for 7.0.

@dannyhw
Copy link
Member Author

dannyhw commented Mar 28, 2023

@JReinhold yeah once v7 is released I will update everything and make sure it works before merging this

* remove unused peerDeps, widen sb devDeps, fix start script

* simplify sb dev deps range
@dannyhw dannyhw merged commit 699e40f into main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants