Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove access-ws and access-client package tests that rely on it #596

Merged
merged 1 commit into from
Mar 22, 2023
Merged

chore: remove access-ws and access-client package tests that rely on it #596

merged 1 commit into from
Mar 22, 2023

Conversation

gobengo
Copy link
Contributor

@gobengo gobengo commented Mar 22, 2023 •
edited
Loading

Motivation:

  • rm /packages/access-ws #593
  • by removing this, my other PR doesn't have to worry about this package anymore (I had to when I encountered some miniflare/wrangler/workers-types/etc type mismatches when adopting R2Bucket type)

Notes

  • this removes some tests in access-client that tested against this access-ws running in miniflare. If we need those back, we can always checkout the things we want back from these commits. Putting #awake here so it shows up in repo search results
    • My understanding is that the websocket used by access-client agent is different than the access-ws package implemented

@gobengo gobengo changed the title remove access-ws and access-client package tests that rely on it chore: remove access-ws and access-client package tests that rely on it Mar 22, 2023
@gobengo gobengo force-pushed the 593-rm-access-ws branch 2 times, most recently from a1fd187 to c88deeb Compare March 22, 2023 18:32
@gobengo gobengo marked this pull request as ready for review March 22, 2023 18:37
@gobengo gobengo requested review from alanshaw, Gozala and travis March 22, 2023 18:37
travis
travis approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@travis travis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gobengo gobengo merged commit 9c34bf7 into main Mar 22, 2023
@gobengo gobengo deleted the 593-rm-access-ws branch March 22, 2023 19:20
@gobengo gobengo mentioned this pull request Mar 22, 2023
Merged
4 tasks
gobengo added a commit that referenced this pull request Mar 23, 2023
@gobengo @Gozala
feat: move access-api delegation bytes out of d1 and into r2 (#578)
4510c9a 
Motivation:
* first PR on #571

todo
* [x] initial `DbDelegationsStorageWithR2` that passes tests as a
`DelegationsStorage`
* [x] rm unused access-ws package
#596
* [x] access-api should use `DbDelegationsStorageWithR2` and not
`DbDelegationsStorage` (without r2) and still pass tests
#599

informed by review
* [x] add r2 bucket name binding to wrangler.toml for staging,
production
#578 (comment)

unblocks:
* `DbDelegationsStorageWithR2` supports deletes
* we don't need this to support current `DelegationsStorage`, but
probably will before long, but doesn't need to block this PR
* optimization where r2 stores all the CIDs with varying multibases but
for the same hash only once
* safe to remove `DbDelegationsStorage`, `DelegationsV2Row`,
`DelegationsV2Tables`

---------

Co-authored-by: Irakli Gozalishvili <[email protected]>
gobengo added a commit that referenced this pull request Apr 11, 2023
@gobengo
chore: remove access-ws and access-client package tests that rely on …
4eec69d 
…it (#596)

Motivation:
* #593 
* by removing this, [my other
PR](#578) doesn't have to
worry about this package anymore (I had to when I encountered some
miniflare/wrangler/workers-types/etc type mismatches when adopting
R2Bucket type)

Notes
* this removes some tests in access-client that tested against this
access-ws running in miniflare. If we need those back, we can always
checkout the things we want back from these commits. Putting #awake here
so it shows up in repo search results
* My understanding is that the websocket used by access-client agent is
different than the access-ws package implemented
gobengo added a commit that referenced this pull request Apr 11, 2023
@gobengo @Gozala
feat: move access-api delegation bytes out of d1 and into r2 (#578)
3029e4a 
Motivation:
* first PR on #571

todo
* [x] initial `DbDelegationsStorageWithR2` that passes tests as a
`DelegationsStorage`
* [x] rm unused access-ws package
#596
* [x] access-api should use `DbDelegationsStorageWithR2` and not
`DbDelegationsStorage` (without r2) and still pass tests
#599

informed by review
* [x] add r2 bucket name binding to wrangler.toml for staging,
production
#578 (comment)

unblocks:
* `DbDelegationsStorageWithR2` supports deletes
* we don't need this to support current `DelegationsStorage`, but
probably will before long, but doesn't need to block this PR
* optimization where r2 stores all the CIDs with varying multibases but
for the same hash only once
* safe to remove `DbDelegationsStorage`, `DelegationsV2Row`,
`DelegationsV2Tables`

---------

Co-authored-by: Irakli Gozalishvili <[email protected]>
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 17, 2025
@github-actions
chore(main): release core 1.0.1 (storacha#596)
1ba62a7 
🤖 I have created a release *beep* *boop*
---


##
[1.0.1](storacha/w3ui@core-v1.0.0...core-v1.0.1)
(2023-11-29)


### Bug Fixes

* update w3up-client
([c22436f](storacha/w3ui@c22436f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 29, 2025
@github-actions
chore(main): release core 1.0.1 (storacha#596)
50c25e5 
🤖 I have created a release *beep* *boop*
---


##
[1.0.1](storacha/w3ui@core-v1.0.0...core-v1.0.1)
(2023-11-29)


### Bug Fixes

* update w3up-client
([1f8e381](storacha/w3ui@1f8e381))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travis travis travis approved these changes

@alanshaw alanshaw Awaiting requested review from alanshaw

@Gozala Gozala Awaiting requested review from Gozala

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gobengo @travis