Skip to content

Commit

Permalink
chore: remove access-ws and access-client package tests that rely on …
Browse files Browse the repository at this point in the history
…it (#596)

Motivation:
* #593 
* by removing this, [my other
PR](#578) doesn't have to
worry about this package anymore (I had to when I encountered some
miniflare/wrangler/workers-types/etc type mismatches when adopting
R2Bucket type)

Notes
* this removes some tests in access-client that tested against this
access-ws running in miniflare. If we need those back, we can always
checkout the things we want back from these commits. Putting #awake here
so it shows up in repo search results
* My understanding is that the websocket used by access-client agent is
different than the access-ws package implemented
  • Loading branch information
gobengo authored Mar 22, 2023
1 parent fa9504b commit 4eec69d
Show file tree
Hide file tree
Showing 18 changed files with 158 additions and 1,560 deletions.
5 changes: 1 addition & 4 deletions packages/access-client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"scripts": {
"lint": "tsc --build && eslint '**/*.{js,ts}' && prettier --check '**/*.{js,ts,yml,json}' --ignore-path ../../.gitignore",
"build": "tsc --build",
"test": "pnpm -r --filter @web3-storage/access-ws run build && npm run test:node && npm run test:browser",
"test": "pnpm -r run build && npm run test:node && npm run test:browser",
"test:node": "mocha 'test/**/!(*.browser).test.js' -n experimental-vm-modules -n no-warnings",
"test:browser": "playwright-test 'test/**/!(*.node).test.js'",
"testw": "watch 'pnpm test' src test --interval 1",
Expand Down Expand Up @@ -93,11 +93,8 @@
"@types/ws": "^8.5.4",
"@ucanto/server": "^6.1.0",
"assert": "^2.0.0",
"delay": "^5.0.0",
"hd-scripts": "^4.0.0",
"miniflare": "^2.11.0",
"mocha": "^10.2.0",
"p-queue": "^7.3.0",
"playwright-test": "^8.1.2",
"sade": "^1.8.1",
"typescript": "4.9.5",
Expand Down
174 changes: 0 additions & 174 deletions packages/access-client/test/awake-channel.node.test.js

This file was deleted.

112 changes: 0 additions & 112 deletions packages/access-client/test/awake.node.test.js

This file was deleted.

24 changes: 0 additions & 24 deletions packages/access-client/test/helpers/miniflare.js

This file was deleted.

Loading

0 comments on commit 4eec69d

Please sign in to comment.