Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: DbProvisionsStorage putMany doesnt error on cid col conflict #517

Merged
merged 7 commits into from
Mar 10, 2023
Merged

fix: DbProvisionsStorage putMany doesnt error on cid col conflict #517

merged 7 commits into from
Mar 10, 2023

Conversation

gobengo
Copy link
Contributor

@gobengo gobengo commented Mar 9, 2023 •
edited
Loading

Motivation:

After 2023-03-09 review with @Gozala :

  • add test for updating Provision with same invocation cid but different derived
    fields. it should result in error
  • make test pass, probably by changing the kysely to be 'on conflict, do nothing as long as the derived columns are identical, otherwise error'

@gobengo gobengo requested a review from Gozala March 9, 2023 00:20
@gobengo gobengo added this to the w3up phase 3 milestone Mar 9, 2023
@gobengo gobengo temporarily deployed to dev March 9, 2023 00:21 — with GitHub Actions Inactive
@gobengo gobengo requested a review from travis March 9, 2023 00:23
@gobengo gobengo self-assigned this Mar 9, 2023
@gobengo
Copy link
Contributor Author

gobengo commented Mar 10, 2023

added some notes on why I did it the way I did in issue above

@gobengo
Copy link
Contributor Author

gobengo commented Mar 10, 2023 •
edited
Loading

@Gozala and I spoke in person and he suggested my last change and said to go ahead and merge this after that

@gobengo gobengo merged commit c1fea63 into main Mar 10, 2023
@gobengo gobengo deleted the provider-add-duplicate branch March 10, 2023 20:36
@it-dag-house it-dag-house mentioned this pull request Mar 10, 2023
Closed
This was referenced Mar 21, 2023
Closed
Merged
alanshaw pushed a commit that referenced this pull request Mar 23, 2023
@it-dag-house
chore(main): release access-api 5.0.0 (#588)
c0fb10a 
🤖 I have created a release *beep* *boop*
---


##
[5.0.0](access-api-v4.11.0...access-api-v5.0.0)
(2023-03-23)


### ⚠ BREAKING CHANGES

* implement new account-based multi-device flow
([#433](#433))
* upgrade capabilities to latest ucanto
([#463](#463))

### Features

* access-api handles provider/add invocations
([#462](#462))
([5fb56f7](5fb56f7))
* access-api serves access/claim invocations
([#456](#456))
([baacf35](baacf35))
* access/authorize confirmation email click results in a delegation back
to the issuer did:key so that access/claim works
([#460](#460))
([a466a7d](a466a7d))
* allow multiple providers
([#595](#595))
([96c5a2e](96c5a2e))
* define `access/confirm` handler and use it in ucanto-test-utils
registerSpaces + validate-email handler
([#530](#530))
([b1bbc90](b1bbc90))
* handle access/delegate invocations without error
([#427](#427))
([4f0bd1c](4f0bd1c))
* if POST /validate-email?mode=authorize catches error w/ too big qr
code ([#516](#516))
([d0df525](d0df525))
* implement new account-based multi-device flow
([#433](#433))
([1ddc6a0](1ddc6a0))
* includes proofs chains in the delegated authorization chain
([#467](#467))
([5144293](5144293))
* move access-api delegation bytes out of d1 and into r2
([#578](#578))
([4510c9a](4510c9a))
* move validation flow to a Durable Object to make it ⏩ fast ⏩ fast ⏩
fast ⏩ ([#449](#449))
([02d7552](02d7552))
* provision provider type is now the DID of the w3s service
([#528](#528))
([6a72855](6a72855))
* space/info will not error for spaces that have had storage provider
added via provider/add
([#510](#510))
([ea4e872](ea4e872))
* upgrade capabilities to latest ucanto
([#463](#463))
([2d786ee](2d786ee))
* upgrade to new ucanto
([#498](#498))
([dcb41a9](dcb41a9))
* write invocations and receipts into ucan log
([#592](#592))
([754bf52](754bf52))


### Bug Fixes

* access/delegate checks hasStorageProvider(space) in a way that
provider/add allows access/delegate
([#483](#483))
([f4c640d](f4c640d))
* adjust migration 0005 to keep delegations table but create new used
delegations_v2
([#469](#469))
([a205ad1](a205ad1))
* adjust migration 0005 to not do a drop table and instead rename
delegations -> delegations_old and create a new delegations
([#468](#468))
([6c8242d](6c8242d))
* allow injecting email
([#466](#466))
([e19847f](e19847f))
* DbDelegationsStorage#find throws UnexpectedDelegation w/ { row } if
failed bytesToDelegations
([#476](#476))
([a6dafcb](a6dafcb))
* DbProvisionsStorage putMany doesnt error on cid col conflict
([#517](#517))
([c1fea63](c1fea63))
* delegations model tries to handle if row.bytes is Array not Buffer
(e.g. cloudflare)
([#478](#478))
([030e7b7](030e7b7))


### Miscellaneous Chores

* **access-client:** release 11.0.0-rc.0
([#573](#573))
([be4386d](be4386d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@it-dag-house it-dag-house mentioned this pull request Mar 23, 2023
Closed
gobengo added a commit that referenced this pull request Apr 11, 2023
@gobengo
fix: DbProvisionsStorage putMany doesnt error on cid col conflict (#517)
8c6dea8 
Motivation:
* #482

* [x] first draft

After 2023-03-09 review with @Gozala :
* [x] add test for updating Provision with same invocation cid but
different derived
fields. it should result in error
* [x] make test pass, probably by changing the kysely to be 'on
conflict, do nothing as long as the derived columns are identical,
otherwise error'
* it wasn't really possible to do that on conflict logic as far as I
could tell, at least through our `kysely` orm
* kysely doesn't expose methods for all the [`on conflict` clauses that
sqlite should support](https://www.sqlite.org/lang_conflict.html)
* I pursued something like [this using
CTE](https://stackoverflow.com/a/49601238), only to find out [sqlite
doesn't support `insert` in
cte](https://sqlite.org/forum/forumpost/b44ca81f043bed9f)
gobengo pushed a commit that referenced this pull request Apr 11, 2023
@it-dag-house
chore(main): release access-api 5.0.0 (#588)
1230e7e 
🤖 I have created a release *beep* *boop*
---


##
[5.0.0](access-api-v4.11.0...access-api-v5.0.0)
(2023-03-23)


### ⚠ BREAKING CHANGES

* implement new account-based multi-device flow
([#433](#433))
* upgrade capabilities to latest ucanto
([#463](#463))

### Features

* access-api handles provider/add invocations
([#462](#462))
([46da0df](46da0df))
* access-api serves access/claim invocations
([#456](#456))
([2ec16e9](2ec16e9))
* access/authorize confirmation email click results in a delegation back
to the issuer did:key so that access/claim works
([#460](#460))
([fc62691](fc62691))
* allow multiple providers
([#595](#595))
([aba57b3](aba57b3))
* define `access/confirm` handler and use it in ucanto-test-utils
registerSpaces + validate-email handler
([#530](#530))
([a08b513](a08b513))
* handle access/delegate invocations without error
([#427](#427))
([db01d07](db01d07))
* if POST /validate-email?mode=authorize catches error w/ too big qr
code ([#516](#516))
([ab83b19](ab83b19))
* implement new account-based multi-device flow
([#433](#433))
([6152e55](6152e55))
* includes proofs chains in the delegated authorization chain
([#467](#467))
([743a72f](743a72f))
* move access-api delegation bytes out of d1 and into r2
([#578](#578))
([3029e4a](3029e4a))
* move validation flow to a Durable Object to make it ⏩ fast ⏩ fast ⏩
fast ⏩ ([#449](#449))
([3868d97](3868d97))
* provision provider type is now the DID of the w3s service
([#528](#528))
([4cd6cd9](4cd6cd9))
* space/info will not error for spaces that have had storage provider
added via provider/add
([#510](#510))
([362024f](362024f))
* upgrade capabilities to latest ucanto
([#463](#463))
([e375ae4](e375ae4))
* upgrade to new ucanto
([#498](#498))
([790750d](790750d))
* write invocations and receipts into ucan log
([#592](#592))
([d52a281](d52a281))


### Bug Fixes

* access/delegate checks hasStorageProvider(space) in a way that
provider/add allows access/delegate
([#483](#483))
([1d3d562](1d3d562))
* adjust migration 0005 to keep delegations table but create new used
delegations_v2
([#469](#469))
([d90825a](d90825a))
* adjust migration 0005 to not do a drop table and instead rename
delegations -> delegations_old and create a new delegations
([#468](#468))
([89f2acd](89f2acd))
* allow injecting email
([#466](#466))
([b4b0173](b4b0173))
* DbDelegationsStorage#find throws UnexpectedDelegation w/ { row } if
failed bytesToDelegations
([#476](#476))
([660f773](660f773))
* DbProvisionsStorage putMany doesnt error on cid col conflict
([#517](#517))
([8c6dea8](8c6dea8))
* delegations model tries to handle if row.bytes is Array not Buffer
(e.g. cloudflare)
([#478](#478))
([02c0c28](02c0c28))


### Miscellaneous Chores

* **access-client:** release 11.0.0-rc.0
([#573](#573))
([29daa02](29daa02))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 17, 2025
@travis
feat: implement uploadCAR in uploader (storacha#517)
40036ea 
This exposes the `upload-client`'s `uploadCAR` function in the
`UploaderProvider`.

---------

Co-authored-by: Travis Vachon <[email protected]>
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 17, 2025
@github-actions
chore(main): release uploader-core 5.2.0 (storacha#522)
dcd84ea 
🤖 I have created a release *beep* *boop*
---


##
[5.2.0](storacha/w3ui@uploader-core-v5.1.0...uploader-core-v5.2.0)
(2023-05-19)


### Features

* implement `uploadCAR` in uploader
([storacha#517](storacha/w3ui#517))
([40036ea](storacha/w3ui@40036ea))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 17, 2025
@github-actions
chore(main): release react-uploader 4.2.0 (#524)
3fad337 
🤖 I have created a release *beep* *boop*
---


##
[4.2.0](storacha/w3ui@react-uploader-v4.1.0...react-uploader-v4.2.0)
(2023-06-20)


### Features

* implement `uploadCAR` in uploader
([storacha#517](storacha/w3ui#517))
([40036ea](storacha/w3ui@40036ea))


### Bug Fixes

* missing `dataCID` in `onUploadComplete` callback
([#525](storacha/w3ui#525))
([fb048a9](storacha/w3ui@fb048a9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 17, 2025
@github-actions @travis
chore(main): release solid-uploader 4.2.0 (storacha#523)
9064623 
🤖 I have created a release *beep* *boop*
---


##
[4.2.0](storacha/w3ui@solid-uploader-v4.1.0...solid-uploader-v4.2.0)
(2023-06-20)


### Features

* implement `uploadCAR` in uploader
([storacha#517](storacha/w3ui#517))
([40036ea](storacha/w3ui@40036ea))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <[email protected]>
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 17, 2025
@github-actions @travis
chore(main): release vue-uploader 4.2.0 (storacha#518)
5dcf552 
🤖 I have created a release *beep* *boop*
---


##
[4.2.0](storacha/w3ui@vue-uploader-v4.1.0...vue-uploader-v4.2.0)
(2023-06-20)


### Features

* implement `uploadCAR` in uploader
([storacha#517](storacha/w3ui#517))
([40036ea](storacha/w3ui@40036ea))


### Bug Fixes

* inferred type error
([storacha#516](storacha/w3ui#516))
([1bf4cf2](storacha/w3ui@1bf4cf2))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gozala Gozala Awaiting requested review from Gozala

@travis travis Awaiting requested review from travis

Assignees

@gobengo gobengo

Labels
None yet
Projects
None yet
Milestone
w3up phase 3
Development

Successfully merging this pull request may close these issues.
1 participant
@gobengo