-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delegate consumer/add on first authorization #518
Comments
|
Yes thanks for flagging |
I have realized there is a major flaw with this proposal and I don't think we should do it, at least the way it has been proposed. Below I'll try to explain the flaw:
This is especially a problem if agent happens to be generated by malicious website. In fact our current What would be a proper approach here ?I think proper solution would be to mediate space creation / registration with a user instead which can be done in a following way:
Difference here is that email takes to you to the page that allows you to create a space and register it as opposed to some agent that can be a malicious app. |
🤖 I have created a release *beep* *boop* --- ## [4.2.0](storacha/w3ui@vue-uploader-v4.1.0...vue-uploader-v4.2.0) (2023-06-20) ### Features * implement `uploadCAR` in uploader ([storacha#517](storacha/w3ui#517)) ([40036ea](storacha/w3ui@40036ea)) ### Bug Fixes * inferred type error ([storacha#516](storacha/w3ui#516)) ([1bf4cf2](storacha/w3ui@1bf4cf2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <[email protected]>
🤖 I have created a release *beep* *boop* --- ## [4.2.0](storacha/w3ui@vue-uploader-v4.1.0...vue-uploader-v4.2.0) (2023-06-20) ### Features * implement `uploadCAR` in uploader ([storacha#517](storacha/w3ui#517)) ([a18d032](storacha/w3ui@a18d032)) ### Bug Fixes * inferred type error ([storacha#516](storacha/w3ui#516)) ([adce6f5](storacha/w3ui@adce6f5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <[email protected]>
Currently registration flow is somewhat complex:
access/authorize
access/claim
provider/add
to install a provider for it.provider/add
prior.We could simplify this a lot by just delegating
consumer/add
capability on first authorization so that in step 2 you'll have get it without having to guessing if you need to doprovider/add
. In other words with this flow the steps would change as follows:access/authorize
access/claim
.consumer/add
wherenb.consumer
is agent DID*
to an account.The text was updated successfully, but these errors were encountered: