Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install correct browser versions for playwright tests #298

Merged
merged 3 commits into from
Jan 27, 2023
Merged

fix: install correct browser versions for playwright tests #298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6dd9d67
fix: install correct browser versions for playwright tests
olizilla Jan 27, 2023
c5012f2
fix: ensure we can run playright:install from project root
olizilla Jan 27, 2023
ff0a7ed
chore: whitespace
olizilla Jan 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/examples.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- uses: actions/checkout@v3
- uses: ./.github/actions/pnpm
- run: pnpm build:examples
- run: pnpx playwright install --with-deps # install browsers
- run: pnpm playwright:install --with-deps # install browsers
- run: pnpm test:examples

# save test report
Expand Down
2 changes: 1 addition & 1 deletion examples/test/playwright/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Install the deps and the browsers from the root of the monorepo
$ pnpm i

# fetch test browsers
$ pnpx playwright install
$ pnpm playwright:install
```

Build the examples to their many dist folders
Expand Down
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@
"typecheck": "tsc -b",
"test:examples": "pnpm run --filter './examples/**' test",
"build:examples": "pnpm run --filter './examples/**' --no-bail build || true",
"serve:examples": "serve examples"
"serve:examples": "serve examples",
"playwright:install": "pnpm --filter './examples/test/playwright' exec playwright install"
},
"devDependencies": {
"@babel/core": "^7.20.12",
Expand Down