fix: install correct browser versions for playwright tests #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by running pnpm exec playwright install from the playwright dir, pnpm knows to use the version of playwright that we depend on rather than the latest version. without this change we end up installing the latest browesers and then the tests fail as they can't find the older versions that they assume will have been installed. ...and it turns out `pnpx` is deprecated, and we should be using `pnpm exec` anyway. fixes: #297 see: https://pnpm.io/6.x/cli/exec License: MIT Signed-off-by: Oli Evans <[email protected]>
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
License: MIT Signed-off-by: Oli Evans <[email protected]>
License: MIT Signed-off-by: Oli Evans <[email protected]>
|
This is a small PR and the goal is to fix the examples test... and the checks show that is done, so i'm gonna merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by running pnpm exec playwright install from the playwright dir, pnpm knows to use the version of playwright that we depend on rather than the latest version.
without this change we end up installing the latest browesers and then the tests fail as they can't find the older versions that they assume will have been installed.
...and it turns out
pnpxis deprecated, and we should be usingpnpm execanyway.fixes: #297
see: https://pnpm.io/6.x/cli/exec
License: MIT
Signed-off-by: Oli Evans [email protected]