Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[setups/vivado] Fix fileset paths #175

Merged
merged 1 commit into from
Oct 8, 2021
Merged

[setups/vivado] Fix fileset paths #175

merged 1 commit into from
Oct 8, 2021

Conversation

henrikbrixandersen
Copy link
Collaborator

Fix the fileset paths in the Vivado project setups. Some were using the wrong path and one was being setup using an undefined variable.

@henrikbrixandersen henrikbrixandersen mentioned this pull request Oct 8, 2021
Merged
umarcor
umarcor approved these changes Oct 8, 2021
View reviewed changes
Copy link
Collaborator

@umarcor umarcor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stnolting
Copy link
Owner

You were faster than me (#174)! 😅

Thanks for fixing this! 👍

@henrikbrixandersen henrikbrixandersen mentioned this pull request Oct 8, 2021
Merged
@stnolting stnolting added the bug Something isn't working as expected label Oct 8, 2021
@stnolting stnolting merged commit c34416b into stnolting:master Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umarcor umarcor umarcor approved these changes

Assignees
No one assigned
Labels
bug Something isn't working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@henrikbrixandersen @stnolting @umarcor