Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read/readwrite: Add option not to check data size #113

Merged
merged 2 commits into from Apr 27, 2020
Merged

read/readwrite: Add option not to check data size #113

merged 2 commits into from Apr 27, 2020

Conversation

ghost
Copy link

@ghost ghost commented Feb 14, 2020

Some structures (such as SAdsSymbolEntry) are dynamically sized, so the
length cannot be checked with the read data size. Allow the user to
disable length checking on request.

@coveralls
Copy link

coveralls commented Feb 14, 2020

Pull Request Test Coverage Report for Build 293

  • 7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 90.932%

Files with Coverage Reduction New Missed Lines %
pyads/pyads_ex.py 1 86.24%
Totals Coverage Status
Change from base Build 286: 0.1%
Covered Lines: 722
Relevant Lines: 794

💛 - Coveralls

Philipp Kerling added 2 commits March 5, 2020 14:09
Some structures (such as SAdsSymbolEntry) are dynamically sized, so the
length cannot be checked with the read data size. Allow the user to
disable length checking on request.
@stlehmann
Copy link
Owner

Almost there. Could you please add an entry to the changelog that describes the changes. Then we are ready to merge.

@stlehmann stlehmann merged commit e7af52e into stlehmann:master Apr 27, 2020
@ghost ghost deleted the read-no-check-size branch May 4, 2020 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants