Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug when calling JSONArray.addAll() with Collection as Object #907

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

hexetia
Copy link
Contributor

@hexetia hexetia commented Oct 5, 2024

That fix the #901 that was introduced in #823

I commented the details of why we need that fix on #901 (comment)

@hexetia hexetia changed the title test(#901): call JsonArray.putAll with a casted list as object fix #901: add the jsonParserConfiguration param when calling addAll with a Collection as Object Oct 5, 2024
@stleary
Copy link
Owner

stleary commented Nov 10, 2024

What problem does this code solve?
Fixes a bug when calling addAll with a collection (infinite recursion)

Does the code still compile with Java6?
Yes

Risks
Low

Changes to the API?
No

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No, a new unit test was added

Was any code refactored in this commit?
No

Review status
APPROVED

Starting 3-day comment window

@stleary stleary changed the title fix #901: add the jsonParserConfiguration param when calling addAll with a Collection as Object Fix a bug when calling JSONArray.addAll() with Collection as Object Nov 10, 2024
@stleary stleary merged commit 2ee5bf1 into stleary:master Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants