JSON parsing self reference object and array #823

sk02241994 · 2023-11-03T14:28:29Z

Fix for issue #743
Self reference issue found in JSONObject and JSONArray

stleary · 2023-11-27T00:10:45Z

@sk02241994 Out of sync, please merge master to your branch.

sk02241994 · 2023-11-27T04:00:38Z

@stleary master is merged to my branch.

src/main/java/org/json/JSONObject.java

- Recursive depth issue found in JSONObject - Recursive depth issue found in JSONArray

src/main/java/org/json/JSONParserConfiguration.java

src/test/java/org/json/junit/JSONObjectTest.java

src/test/java/org/json/junit/JSONArrayTest.java

stleary · 2023-12-22T17:02:01Z

@sk02241994 For now, we just want JSONParserConfiguration to act as a marker class. All of the required functionality is already in the base class ParserConfiguration, so you can leverage that. Future commits will add more config properties.
Will go through the changes to JSONObject and JSONArray later.

src/main/java/org/json/JSONParserConfiguration.java

src/main/java/org/json/JSONArray.java

stleary · 2023-12-23T17:16:04Z

src/main/java/org/json/JSONArray.java

+     * @param value
+     *          The Map value.
+     * @param jsonParserConfiguration
+     *          Configuration for recursive depth


Please just call this a configuration object. The things that it can configure will change going forward

src/main/java/org/json/JSONArray.java

stleary · 2023-12-23T17:19:15Z

src/main/java/org/json/JSONArray.java

-     *
+     * @param recursionDepth
+     *            Variable to keep the count of how nested the object creation is happening.
+     * @param recursionDepth


Please change to jsonParserConfiguration

src/main/java/org/json/JSONObject.java

stleary · 2023-12-23T17:48:32Z

@sk02241994 Looks good, couple remaining items to clean up, nothing functional though.

stleary · 2023-12-24T17:38:45Z

What problem does this code solve?
Fixes potential stackoverflow errors due to exceeding maximum nesting depth

Does the code still compile with Java6?
Yes

Risks
Low

Changes to the API?
No, some new API methods were added

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No. Also, new unit tests were added.

Was any code refactored in this commit?
No

Review status
APPROVED

Starting 3-day comment window

stleary added the In review label Nov 4, 2023

stleary added the Pending response from submitter label Nov 27, 2023

sk02241994 force-pushed the issue_743 branch from 9b090d1 to 2dd0f83 Compare November 27, 2023 03:59

stleary removed the Pending response from submitter label Nov 27, 2023

stleary reviewed Nov 28, 2023

View reviewed changes

src/main/java/org/json/JSONObject.java Outdated Show resolved Hide resolved

stleary added the Pending response from submitter label Nov 28, 2023

stleary changed the title ~~JSON parsion self reference object and array~~ JSON parsing self reference object and array Dec 9, 2023

stleary mentioned this pull request Dec 9, 2023

JSONObject stack overflow #837

Open

sk02241994 added 3 commits December 22, 2023 15:47

Resolving issue stleary#743

6d81160

- Recursive depth issue found in JSONObject - Recursive depth issue found in JSONArray

Adding test case for nested json with depth of 999, 1000, 1001

dcac3bc

Adding JSONParserConfiguration for configuring the depth of nested maps

abea194

sk02241994 force-pushed the issue_743 branch from d493fee to abea194 Compare December 22, 2023 10:18