Misc improvements to tests #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will address this snapshot issue causing build failure - seen this before! |
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 22 22
Lines 183 183
Branches 39 39
=====================================
Hits 183 183
Continue to review full report at Codecov.
|
|
@stevesims All now passing. |
stevesims
reviewed
Aug 10, 2018
components/remove-button/src/test.js
Outdated
| }); | ||
|
|
||
There was a problem hiding this comment.
hmm - whitespace on an empty line should i believe be a linting error
stevesims
reviewed
Aug 10, 2018
| }); | ||
|
|
||
There was a problem hiding this comment.
another case of whitespace on an otherwise empty line...
stevesims
previously approved these changes
Aug 10, 2018
gavinorland
force-pushed
the
feature/improve-unit-tests
branch
2 times, most recently
from
b8120cb to
eea8793
Compare
Fix snapshot discrepancy n.b. Also adjust Jest config as per jestjs/jest#6766 (comment) Remove whitespace Minor fixes
gavinorland
force-pushed
the
feature/improve-unit-tests
branch
from
eea8793 to
3ce053f
Compare
|
Now up-to-date with |
stevesims
approved these changes
Aug 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #57 and implements:
exists()describeblocks)expect()per test and wrappers usually include only tested props)setProps()describeblocksmountandshallowmountand full range of props)Coverage remains at 100%.