Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider changing test structuring #57

Closed
gavinorland opened this issue Aug 7, 2018 · 2 comments
Closed

Consider changing test structuring #57

gavinorland opened this issue Aug 7, 2018 · 2 comments
Assignees
@gavinorland

Comments

@gavinorland
Copy link
Collaborator

@stevesims raises some points in #52 about the way variables are set up and amended and reused in Jest tests at the moment.

Maybe it is better to have tests able to be entirely independent, even if this means more generation of wrappers etc. We can at least see where things might be refined and improved across tests, probably in a new branch.
@gavinorland gavinorland self-assigned this Aug 9, 2018
@gavinorland
Copy link
Collaborator Author

I was just trying to be as efficient as possible with the tests, but I think Steve is right that there is actually very little loss and some solid gain from scoping the variables differently here. Therefore I'm going to quickly rework them and go with that in future.

@gavinorland gavinorland mentioned this issue Aug 10, 2018
Merged
@gavinorland
Copy link
Collaborator Author

Closed via #67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gavinorland gavinorland

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gavinorland