Merge pull request #229 from stereotech/STEAPP-866

STEAPP-866: fixed a bug where the v750 printer turned off the chamber_fan fan when printing
stereotech · Jan 29, 2024 · ade0d94 · ade0d94
2 parents a422b46 + b848436
commit ade0d94
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 45 deletions.
diff --git a/stereotech_config/750/chamber.cfg b/stereotech_config/750/chamber.cfg
@@ -1,29 +1,6 @@
-# [fan_generic chamber_fan]
-# pin: second_mcu: cooling_fan_heat
-
-# for fan webcam
+# FOR FAN WEBCAM
 # [fan_generic webcam_fan]
 # pin: second_mcu: cooling_fan_heat
-[heater_generic chamber_heater]
-gcode_id: C
-heater_pin: multi_pin:chamber_heater
-sensor_type: ATC Semitec 104GT-2
-sensor_pin: chamber_sensor_pin
-control: pid
-pid_Kp: 44.327
-pid_Ki: 0.211
-pid_Kd: 2332.142
-min_temp: -150
-max_temp: 200
-
-[heater_fan chamber_fan]
-pin: chamber_fan_pin
-heater: chamber_heater
-heater_temp: 40
-
-#ONLY FOR DEBUG
-[verify_heater chamber_heater]
-check_gain_time: 1000
 
 [output_pin chamber_led]
 pin: manta_mcu:chamber_led_pin
@@ -52,28 +29,20 @@ rename_existing: M106.1
 gcode:
     {% set p = params.P|default(0)|int %}
     {% set s = params.S|default(0)|int %}
-    {% if p == 3 %}
-        HEATER_FAN_TEST FAN=chamber_fan SPEED=1.0
-    {% else %}
-        M106.1 S255 ;TURN ON PUMP
-        {% if p == 1 %}
-            SET_PIN PIN=extruder1_cooling_valve VALUE=1
-        {% else %}
-            SET_PIN PIN=extruder_cooling_valve VALUE=1
-        {% endif %}
+    M106.1 S255 ;TURN ON PUMP
+    {% if p == 0 %}
+        SET_PIN PIN=extruder_cooling_valve VALUE=1
+    {% elif p == 1 %}
+        SET_PIN PIN=extruder1_cooling_valve VALUE=1
     {% endif %}
 
 [gcode_macro M107]
 rename_existing: M107.1
 gcode:
     {% set p = params.P|default(0)|int %}
-    {% if p == 3 %}
-        HEATER_FAN_TEST FAN=chamber_fan SPEED=0.0
-    {% else %}
-        M107.1 ;TURN OFF PUMP
-        {% if p == 1 %}
-            SET_PIN PIN=extruder1_cooling_valve VALUE=0
-        {% else %}
-            SET_PIN PIN=extruder_cooling_valve VALUE=0
-        {% endif %}
+    M107.1 ;TURN OFF PUMP
+    {% if p == 0 %}
+        SET_PIN PIN=extruder_cooling_valve VALUE=0
+    {% elif p == 1 %}
+        SET_PIN PIN=extruder1_cooling_valve VALUE=0
     {% endif %}
diff --git a/stereotech_config/750/chamber_heater.cfg b/stereotech_config/750/chamber_heater.cfg
@@ -4,11 +4,17 @@ heater_pin: multi_pin:chamber_heater
 sensor_type: ATC Semitec 104GT-2
 sensor_pin: chamber_sensor_pin
 control: pid
-pid_Kp: 39.120
-pid_Ki: 0.196
-pid_Kd: 1955.496
+pid_Kp: 44.327
+pid_Ki: 0.211
+pid_Kd: 2332.142
 min_temp: -150
 max_temp: 200
+# test0 (open door)
+# pid_Kp=39.120 pid_Ki=0.196 pid_Kd=1955.496
+# test1
+#pid_Kp=45.436 pid_Ki=0.220 pid_Kd=2341.109
+# test2
+#pid_Kp=44.327 pid_Ki=0.211 pid_Kd=2332.142
 
 [heater_fan chamber_fan]
 pin: chamber_fan_pin