Only run ci on push to real branches #4375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #4373 fixing yet another issue that seems to be happening with merge queues, it's visible in this screenshot:
I believe what's happening here is that the merge queue machinery is kicking off two separate groups of actions simultaneously, one corresponding to the
pushevent on the temporary integration branch, and the other corresponding to themerge_groupevent "Merge group checks requested". We should really only be triggering on themerge_groupevent, so this PR limits thepushevents that trigger actions to only the final pushes when the integration branch closes and the queue pushes to master (which is still a somewhat redundant build, but the only way we can ensure the cache gets rewritten, and anyways it's only two action-triggers per PR, vs. the current three).(Also note this is really a copy-paste mistake on my part, Leigh did this correctly on the soroban repos)