Misc fixes to the caching logic #4373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes several different minor issues in caching:
- Caches the whole .cargo directory, including bins
- Caches the new (moved) location of the rust target dir
- Turns off the scheduled cache-priming runs, they're not needed
- Explicitly limits cache-writes to happen on master instead
- Eliminates a redundant (harmless but noisy) attempted cache-write
when running the two different 'scenario' matrix variants
sisuresh
approved these changes
Jun 28, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 1, 2024
This is a followup to #4373 fixing yet another issue that seems to be happening with merge queues, it's visible in this screenshot:  I believe what's happening here is that the merge queue machinery is kicking off _two_ separate groups of actions simultaneously, one corresponding to the `push` event on the temporary integration branch, and the other corresponding to the `merge_group` event "Merge group checks requested". We should really only be triggering on the `merge_group` event, so this PR limits the `push` events that trigger actions to only the _final_ pushes when the integration branch closes and the queue pushes to master (which is still a somewhat redundant build, but the only way we can ensure the cache gets rewritten, and anyways it's only _two_ action-triggers per PR, vs. the current _three_). (Also note this is really a copy-paste mistake on my part, Leigh did this correctly on the soroban repos)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes several different minor issues in caching: