Pin cxxbridge tool at v 1.0.68 to match Cargo.lock.
#3585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ideally we would do that automatically, but that addresses the issue of version mismatch for the time being.
| @@ -76,7 +76,7 @@ stellar_core_LDADD += $(LIBRUST_STELLAR_CORE) -ldl | |||
|
|
|||
| $(RUST_CXXBRIDGE): | |||
| mkdir -p $(RUST_BIN_DIR) | |||
| $(CARGO) install --root $(RUST_BUILD_DIR) cxxbridge-cmd | |||
| $(CARGO) install --root $(RUST_BUILD_DIR) cxxbridge-cmd --version 1.0.68 | |||
There was a problem hiding this comment.
Fyi if you want to extract this from the Cargo.lock file so you don't have to manually keep it in sync, you can use this command, or something like this:
cargo metadata --format-version 1 | jq -r '.packages[] | select(.name == "cxx") | .version'
I don't know how anything like that could be applied to the VisualStudio project file, but this would work for the Makefile at least.
|
r+ 3c16f19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pin
cxxbridgetool at v 1.0.68 to matchcxxcrates inCargo.lock.Ideally we would do that automatically, but that addresses the issue of version mismatch for the time being.
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)