Skip to content

Commit

Permalink
Pin cxxbridge tool at v 1.0.68 to match Cargo.lock.
Browse files Browse the repository at this point in the history
Ideally we would do that automatically, but that addresses the issue of version mismatch for the time being.
  • Loading branch information
dmkozh committed Oct 25, 2022
1 parent ca2fb06 commit 3c16f19
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions Builds/VisualStudio/stellar-core.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -1526,8 +1526,8 @@ $(OutDir)\bin\cxxbridge.exe ..\..\src\rust\src\lib.rs --output src\$(Configurati
</CustomBuild>
<CustomBuild Include="..\..\src\rust\install-cxxbridge-cmd">
<FileType>Document</FileType>
<Command>cargo install --root $(OutDir) cxxbridge-cmd</Command>
<Message>cargo install --root $(OutDir) cxxbridge-cmd</Message>
<Command>cargo install --root $(OutDir) cxxbridge-cmd --version 1.0.68</Command>
<Message>cargo install --root $(OutDir) cxxbridge-cmd --version 1.0.68</Message>
<Outputs>$(OutDir)/bin/cxxbridge.exe</Outputs>
</CustomBuild>
<None Include="..\..\src\rust\src\b64.rs" />
Expand Down
2 changes: 1 addition & 1 deletion src/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ stellar_core_LDADD += $(LIBRUST_STELLAR_CORE) -ldl

$(RUST_CXXBRIDGE):
mkdir -p $(RUST_BIN_DIR)
$(CARGO) install --root $(RUST_BUILD_DIR) cxxbridge-cmd
$(CARGO) install --root $(RUST_BUILD_DIR) cxxbridge-cmd --version 1.0.68

rust/RustBridge.h: rust/src/lib.rs $(SRC_RUST_FILES) Makefile.am $(RUST_CXXBRIDGE)
$(RUST_CXXBRIDGE) $< --header --output $@.tmp
Expand Down

5 comments on commit 3c16f19

@latobarita
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from MonsieurNicolas
at dmkozh@3c16f19

@latobarita
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dmkozh/stellar-core/pin_cxx_bridge = 3c16f19 merged ok, testing candidate = ef6285d

@latobarita
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging dmkozh/stellar-core/pin_cxx_bridge = 3c16f19 into auto

@latobarita
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = ef6285d

Please sign in to comment.