Reduce false positives in rust-analyzer compat ci check #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graydon
approved these changes
Jun 20, 2023
leighmcculloch
added a commit
that referenced
this pull request
Jun 20, 2023
### What Revert to using nightly for rust-analyzer compat check. ### Why I changed the version of rust-analyzer to the stable version in #994 however it seems to be much much slower for some reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Only consider lines output from rust-analyzer as an error if they begin with
[ERROR.Why
We've started to see some false positives where the word ERROR appears in non-error output.
Also, updates the version of rust-analyzer to be the version shipped with stable, since it now ships with stable.