Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: fix rust-analyzer testing #712

Merged
merged 2 commits into from
Jun 21, 2023
Merged

rust: fix rust-analyzer testing #712

merged 2 commits into from
Jun 21, 2023

Conversation

tsachiherman
Copy link
Contributor

What

Following a recent dependency update, the rust-analyzer started failing when executing the following:

rustup run nightly rust-analyzer analysis-stats . 2>&1 | (! grep ERROR)

Why

One of the dependencies was including the text "ERROR", which caused this test to fail. This is a false-positive,
since there is no actual failure here. The solution here is to omit the stdout and use the stderr only when scanning for the "ERROR" text.

Known limitations

N/A

@tsachiherman tsachiherman self-assigned this Jun 21, 2023
@tsachiherman tsachiherman marked this pull request as ready for review June 21, 2023 18:54
@tsachiherman tsachiherman merged commit 02f47b7 into main Jun 21, 2023
@tsachiherman tsachiherman deleted the tsachi/fixrustanalyzer branch June 21, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants