support/db: Add benchmark for BatchInsertBuilder #4086
Conversation
2opremio
force-pushed
the
batch-insert-benchmark
branch
from
4ab3e7d
to
de10ba3
Compare
2opremio
force-pushed
the
batch-insert-benchmark
branch
2 times, most recently
from
1764255
to
641ddac
Compare
2opremio
force-pushed
the
batch-insert-benchmark
branch
from
641ddac
to
e1d6fa5
Compare
| Table: sess.GetTable("people"), | ||
| MaxBatchSize: maxBatchSize, | ||
| } | ||
| b.StartTimer() |
There was a problem hiding this comment.
would it make sense to use b.ResetTimer() here instead of stoping and then starting?
There was a problem hiding this comment.
auto-merge merged before I could resolve this, sorry.
I thought @leighmcculloch changed the repo config so that all comments had to be resolved before auto-merged kicked in?
There was a problem hiding this comment.
@tamirms you are right, it's a better option. I will change it later on 👍
There was a problem hiding this comment.
Even though terraform does not support configuring the wait for conversations to be resolved, it appears it is being cleared on multiple repos, this one and the starlight repo. Maybe the terraform integration is clearing it on every deploy. I think this means we can't use the wait for conversations feature until integrations/terraform-provider-github#868 is resolved.
It might be worth holding off on using auto-merge until this is resolved. The GitHub terraform provider usually ships new features quickly so we might not be waiting that long.
cc @stellar/ops-team
No description provided.