xdr and support/db: Minor benchmark code quality improvements #4093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamirms
reviewed
Nov 23, 2021
| @@ -41,6 +41,7 @@ func BenchmarkXDRUnmarshalWithReflection(b *testing.B) { | |||
| r bytes.Reader | |||
| te xdr.TransactionEnvelope | |||
| ) | |||
| b.ReportAllocs() | |||
There was a problem hiding this comment.
nice!! I didn't know about b.ReportAllocs
tamirms
reviewed
Nov 23, 2021
2opremio
force-pushed
the
refine-benchmarks
branch
from
4a03e71
to
f918eb2
Compare
|
@tamirms PTAL |
tamirms
approved these changes
Nov 23, 2021
erika-sdf
pushed a commit
to erika-sdf/go
that referenced
this pull request
Dec 3, 2021
…r#4093) * Minor benchmark code quality improvements * Address review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It includes a leftover from #4086