-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errors not thrown #88
Comments
Chrome actually doesn't throw them, rather an unspeced log. I agree it would be good to add that back to this project. |
Bump. This is strange behaviour. |
Throwing via setTimeout isn't the right solution here - as Stefan points On Tue, 31 Mar 2015 00:49 Allan Hortle [email protected] wrote:
|
I've been saturated with other OSS responsibilities, but I will circle around and push this forward :) |
@stefanpenner I can help. So one way to do this would be:
|
awesome, but its has a few more requirements. I have implemented something (quick and dirty) that closely mimics (but doesn't quite match) the expected heuristics. in RSVP (the parent project) https://github.com/tildeio/rsvp.js/blob/master/lib/rsvp/promise.js#L176-L182 It would actually be easier to implement it more heuristically correct in this project, as the async isn't pluggable as it is in ember. So basically, Errors are logged only if not handled before the next macroTask. So their is a concise window where errors need to be handled, and where errors need to be logged. |
Don't you think "the next macrotask" is too soon? |
i don't believe so, we really need the browsers to give us access to their new promise pane.... |
@domenic share your thoughts? |
I'd just log on next macrotask and log again when it's caught. Chrome still is implementing the last part. |
duplicate: #70 |
the last part being, giving userland promises access to the new promise pane? |
No, greying out the log when the rejection gets handled. |
@domenic lame :P |
Event Chrome and Bluebird is not good enough for me. I wrote mine, see the comparison: https://github.com/ysmood/yaku/blob/master/docs/debugHelperComparison.md For more details: https://github.com/ysmood/yaku |
Chrome 41 throws uncatched errors using native
window.Promise
:The only way i can achieve this behavior using
es6-promise
is by re-throwing in asetTimeout
incatch
:This is not developer-friendly at all.
While i've read #70, #71 and especially #40 i don't get how this is specced behavior. Can't find anything in the current ES6 draft on this.
Maybe someone can shed a little light.
The text was updated successfully, but these errors were encountered: