Error stops execution

[adius]

I have following function which returns a promise:

function getStats (filePath) {
    return new Promise(function (fulfill, reject) {
        fs.stat(filePath, function (error, stats) {
            if (error)
                reject(error)
            else
                fulfill(stats)
        })
    })
}

Unfortunately I forgot to require fs before.
The outcome was, that the execution of the code stopped when I used the promise later.
Is this the correct behavior and how am I supposed to catch the exception then?

[adius]

Oh, just saw that #70 is basically the same…

[adius]

The correct fix seems to be:

function getStats (filePath) {
    return new Promise(function (fulfill, reject) {
        try {
            fs.stat(filePath, function (error, stats) {
                if (error)
                    reject(error)
                else
                    fulfill(stats)
            })
        }
        catch (error) {
            reject(error)
        }
    })
}

[stefanpenner]

dupe of #70 the promise works correctly, but we should likely activate the extra logging in this project.