Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable validation when no config file is present #188

Closed
moeriki opened this issue Aug 27, 2014 · 6 comments
Closed

Disable validation when no config file is present #188

moeriki opened this issue Aug 27, 2014 · 6 comments

Comments

@moeriki
Copy link

moeriki commented Aug 27, 2014

As suggested @dmnd AtomLinter/linter-jscs#18

Do you concur this has a place in the Linter core?

@dmnd
Copy link

dmnd commented Aug 27, 2014

👍 I agree, PRs welcome 😄

@iam4x
Copy link
Contributor

iam4x commented Feb 18, 2015

@dmnd @moeriki I think this should be linter specific. Maybe I want to have linter-jshint lint everywhere, and lint-jscs only if a config file is present.

@hd-deman
Copy link
Contributor

@iam4x I think this can be in Linter and can be overridden by specific linter.

@iam4x
Copy link
Contributor

iam4x commented Feb 18, 2015

This will add work on Linter and on every linters too, and have to go to
Linter configuration and then every linters too for the user.

But if you guys prefere on Linter, I'm okay with it.

On Wednesday, February 18, 2015, Dmitry Tsoy [email protected]
wrote:

@iam4x https://github.com/iam4x I think this can be in Linter and can
be overridden by specific linter.


Reply to this email directly or view it on GitHub
#188 (comment).

@dmnd
Copy link

dmnd commented Feb 18, 2015

Fair point @iam4x. I haven't fully thought this through, but I can imagine a nice "just works" default setup would satisfy the following:

  1. You can have a linter installed, but not active for projects/files for which it is irrelevant
  2. If a config file is present, a matching linter should definitely lint that project
  3. It might be desirable to have a "personal" linter that is active regardless of project settings (perhaps this is trigged by a config file in ~? Or maybe it's always active like we have now)

Right now we assume every installed linter is active all the time. So 3 is satisfied, but 1 is difficult. Working across multiple projects that use different linters can be annoying (jshint vs eslint or pyflakes vs pylint)

It seems this setup is more complex than I had in mind when I made the suggestion in AtomLinter/linter-jscs#18.

@iam4x
Copy link
Contributor

iam4x commented Feb 18, 2015

I think we can do some work on base Linter to have easy-implementation for linters to achieve this. Because right now it's kinda hard to have something clean, see AtomLinter/linter-jscs@ff78305

But imagine a linter that not take any config, will he be always un-activated? This may be a breaking change for every linters.

I think we should wait, think about an implementation for 2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants