peerDeps React 19 #242
Closed
peerDeps React 19 #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-d-boiko
approved these changes
Dec 24, 2024
|
mmm sorry, it was meant to be a PR on my own fork, not the upstream repo. But IMHO you should still allow React 19 as peerDeps As the maintainer of Docusaurus, I can see that this lib (v1.3.0) works fine under React 19. However, I don't know if v2.x works. We didn't upgrade to v2 because it's not clear to me what the v2 breaking changes are (no changelog nor release notes 🤷 ), so I just published a fork of v1.3.0 that allows React 19 and it's working fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the forked v1.3 version adding support for React 19 in Docusaurus (see facebook/docusaurus#10763)
I didn't upgrade to v2 and used an old tag for the fork because it's not clear what the v2 breaking changes are (undocumented, no changelog)