feat: Add React 19 support to Docusaurus v3 #10763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Size Change: +74.6 kB (+0.66%) Total Size: 11.4 MB
ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: +77.9 kB (+0.66%) Total Size: 11.8 MB
ℹ️ View Unchanged
|
slorber
added
the
Argos
This was referenced Dec 20, 2024
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
…slorber/react-19-peerDeps
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Allow Docusaurus v3 to support React 19 in a retro-compatible way.
Support for React 18 is preserved, and it's not required for existing Docusaurus v3.x sites to upgrade immediately.
To ensure it works properly, we'll use React 19 on:
Since we don't leverage v19 features yet, most sites can keep using React v18. According to our CI tooling, React v19 is heavier than v18 and consumes a bit more memory.
We recommend upgrading to React 19 only if you have a good reason to:
Fix #10750
Fix #9985
Worth mentioning: React 19 emits warnings when using React-Live playgrounds, due to the lack of JSX automatic runtime support. However, it's only a warning and works fine. See FormidableLabs/react-live#405
We are also using a new fork for
"react-helmet-async": "npm:@slorber/[email protected]": since the lib kind-of unmaintained, doesn't declare React 19 as peerDeps, and doesn't have any changelog, it wasn't clear if v2 contained breaking changes, so I forked from latest v1.x to ensure retro-compatibility.Test Plan
CI + dogfood React 19 on our website + init templates (on which e2e tests run)
Test links
https://deploy-preview-10763--docusaurus-2.netlify.app/