Use filter protocol #301
Closed
Use filter protocol #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felicio
commented
Aug 1, 2022
| method: waku_message.DecryptionMethod.Symmetric, | ||
| contentTopics: [contentTopic], | ||
| }) | ||
|
|
||
| const unsubscribe = await this.client.waku.filter.subscribe( |
There was a problem hiding this comment.
todo: see stream limits and consider changing js-waku/go-waku's so one content topic can be unsubscribed from a stream serving many other topics without service interruption
| } | ||
|
|
||
| private unobserveChatMessages = ( | ||
| private unobserveChatMessages = async ( |
There was a problem hiding this comment.
note: await where called
| @@ -52,7 +54,8 @@ export class Community { | |||
| this.client.waku.store.addDecryptionKey(this.symmetricKey, { | |||
| contentTopics: [this.contentTopic], | |||
| }) | |||
| this.client.waku.relay.addDecryptionKey(this.symmetricKey, { | |||
| // this.client.waku.relay.addDecryptionKey(this.symmetricKey, { | |||
| this.client.waku.filter.addDecryptionKey(this.symmetricKey, { | |||
There was a problem hiding this comment.
todo: explain why to filter now and when to relay again
felicio
commented
Aug 1, 2022
| }, | ||
| // todo: don't relay | ||
| relayKeepAlive: 15, |
There was a problem hiding this comment.
todo: use diff pinging
felicio
commented
Aug 1, 2022
| relayKeepAlive: 15, | ||
| libp2p: { config: { pubsub: { enabled: true, emitSelf: true } } }, | ||
| }) | ||
| await waku.waitForRemotePeer() | ||
| console.log('waku:ready', new Date().toISOString()) | ||
| const wakuDisconnectionTimer = setInterval(async () => { |
There was a problem hiding this comment.
todo: see if works for Filter too
Closed
Merged
|
Closed by 2d36345 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.