-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add predefined nodes #313
Add predefined nodes #313
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just pass the array of peers to the js-waku
instead of replicating this functionality? If we could use PeerDiscoveryStaticPeers
similarly to default option, which uses the pseudo-random subset during initialization.
I don't understand the purpose of shuffle
. ¯\_(ツ)_/¯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's raise an issue about peers not working if they won't work by the end of the day.
@prichodko without some kind of randomization, and in case of only 1 max peer, users would always be hitting one specific node |
I see it now. I should've read the code better. But why shuffle an array instead of choosing a random number between 0 and |
@prichodko, yeah, had the same question. I'd say it comes down to the randomization func/algo. Pseudo-random in the naming suggests:
Didn't question it further. |
No description provided.