Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to swipe through composer link previews in case of multiple links message #16599

Closed
pavloburykh opened this issue Jul 13, 2023 · 8 comments · Fixed by #17680
Closed

Unable to swipe through composer link previews in case of multiple links message #16599

pavloburykh opened this issue Jul 13, 2023 · 8 comments · Fixed by #17680
Assignees
@ilmotta
Labels
url-preview
Milestone
1.26.0 - Alpha

Comments

@pavloburykh
Copy link
Contributor

Steps:

  1. Paste message containing multiple links into composer
  2. Wait until link previews are fetched
  3. Try to swipe through link previews
  4. Observe the result

Actual result: Unable to swipe through link previews

telegram-cloud-document-2-5296414263378720340.mp4

Expected result: user is able to swipe through link previews

Additional Information

  • Status version: nightly
  • Operating System: Android, iOS
@pavloburykh pavloburykh added this to the 1.25.0 - Alpha milestone Jul 13, 2023
@ibrkhalil ibrkhalil self-assigned this Jul 20, 2023
@ibrkhalil
Copy link
Contributor

Unassigning as I couldn't reproduce locally

@ibrkhalil ibrkhalil removed their assignment Jul 20, 2023
@pavloburykh
Copy link
Contributor Author

pavloburykh commented Jul 20, 2023 •
edited
Loading

Unassigning as I couldn't reproduce locally

@ibrkhalil so in your case swiping of multiple previews is working fine? Could you please share a video of how it works locally? Thank you!

@ibrkhalil ibrkhalil self-assigned this Aug 5, 2023
@ibrkhalil
Copy link
Contributor

Blocked by #16457

@ibrkhalil
Copy link
Contributor

ibrkhalil commented Aug 19, 2023 •
edited
Loading

It works after a few tries, So I can confirm this is an issue.
Sorry for the misunderstanding, Investigating.

@ibrkhalil
Copy link
Contributor

Screen_recording_20230819_225913.mp4

So I get that it has some issues with having to try multiple times to get it, Because it conflicts with composer's gesture.
What should we do in this case?

@ibrkhalil ibrkhalil removed their assignment Aug 30, 2023
@pavloburykh pavloburykh mentioned this issue Oct 6, 2023
Merged
@pavloburykh
Copy link
Contributor Author

So I get that it has some issues with having to try multiple times to get it

I am not able to swipe no matter how many times I'm trying.

@ilmotta
Copy link
Contributor

ilmotta commented Oct 6, 2023

I remember fixing this issue during development, before releasing the first version of the link previews. I'm not surprised this bug exists tbh, but I think something changed in the composer that caused brought this bug to surface.

@ilmotta
Copy link
Contributor

ilmotta commented Oct 6, 2023

I will take a look at this one.

@ilmotta ilmotta self-assigned this Oct 6, 2023
@ilmotta ilmotta mentioned this issue Oct 18, 2023
Merged
ilmotta added a commit that referenced this issue Nov 1, 2023
@ilmotta
Composer - Fix conflicting touchable and gesture (#17680)
972e1ee 
Fix the unreliable swipe behavior of link previews in the chat composer. In many
occasions, we noticed the horizontal scroll wasn't being triggered properly or
not at all. In other occasions, the swipe gesture would incorrectly register a
press on the parent `Touchable` component.

Fixes #16599
yevh-berdnyk pushed a commit that referenced this issue Dec 8, 2023
@ilmotta @yevh-berdnyk
Composer - Fix conflicting touchable and gesture (#17680)
c87c13f 
Fix the unreliable swipe behavior of link previews in the chat composer. In many
occasions, we noticed the horizontal scroll wasn't being triggered properly or
not at all. In other occasions, the swipe gesture would incorrectly register a
press on the parent `Touchable` component.

Fixes #16599
@ilmotta ilmotta removed the bug label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilmotta ilmotta

Labels
url-preview
Projects
None yet
Milestone
1.26.0 - Alpha
Development

Successfully merging a pull request may close this issue.

Composer - Fix conflicting touchable and gesture status-im/status-mobile
4 participants
@ilmotta @cammellos @ibrkhalil @pavloburykh