Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages containing Giphy/Tenor links are not delivered to receiver #16457

Closed
pavloburykh opened this issue Jun 30, 2023 · 3 comments
Closed

Comments

@pavloburykh
Copy link
Contributor

Originally reported here #15891 (comment)

Example of giphy link: https://giphy.com/gifs/this-is-fine-QMHoU66sBXqqLqYvGO
Example of tenor link: https://tenor.com/view/wolf-of-wall-street-media-leonardo-di-caprio-tapping-table-happy-gif-17819377

Steps:

  1. User A sends given link in chat
  2. See if User B received this link

Actual result: link is not delivered to User B. Any message containing such link will not be delivered to receiver.

giphy_not_delivered.mp4

Additional Information

  • Status version: nightly
  • Operating System: Android, iOS
@ibrkhalil
Copy link
Contributor

We need to look into what compression looks like for gifs, Because sending them over the wire is expensive (In MBs), This not high priority at the moment.

@ibrkhalil ibrkhalil removed their assignment Aug 28, 2023
@cammellos cammellos removed this from the 1.25.0 - Alpha milestone Sep 5, 2023
@cammellos
Copy link
Contributor

Please don't pick this up until, we need to do a spike on gifs compression before (if you want to do this fine, but timebox it please)

@churik
Copy link
Member

churik commented Jun 21, 2024

Links are delivered with preview on 2.29, closing the issue

@churik churik closed this as completed Jun 21, 2024
@ilmotta ilmotta removed the bug label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants