Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_: unique project per run #5996

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Conversation

antdanchenko
Copy link
Contributor

@antdanchenko antdanchenko commented Oct 28, 2024

fixes 2 issues:

  1. Error response from daemon: Conflict. The container name "/964f2dd64c34_tests-functional-status-go-1" is already in use by container "0fe8766cc6c9e155217924d13ef196e97094eef2b67978d15901a928acde5309". You have to remove (or rename) that container to be able to reuse that name.

  2. second session attaches to the first instead of rebuilding containers with status-backend when a session is already running and another session starts

  3. Fixes Functional tests running on develop branch don't report failure #5980

@status-im-auto
Copy link
Member

status-im-auto commented Oct 28, 2024

Jenkins Builds

Click to see older builds (14)
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ 04edb54 #1 2024-10-28 13:07:13 ~3 min tests 📄log
✔️ 04edb54 #1 2024-10-28 13:08:56 ~5 min macos 📦zip
✔️ 04edb54 #1 2024-10-28 13:09:01 ~5 min linux 📦zip
✔️ 04edb54 #1 2024-10-28 13:09:31 ~6 min macos 📦zip
✔️ 04edb54 #1 2024-10-28 13:09:36 ~6 min android 📦aar
✔️ 04edb54 #1 2024-10-28 13:09:40 ~6 min tests-rpc 📄log
✖️ 04edb54 #1 2024-10-28 13:13:50 ~10 min windows 📦zip
✔️ 6c35178 #2 2024-10-28 13:28:20 ~4 min macos 📦zip
✔️ 6c35178 #2 2024-10-28 13:29:33 ~5 min linux 📦zip
✔️ 6c35178 #2 2024-10-28 13:29:38 ~5 min tests-rpc 📄log
✔️ 6c35178 #2 2024-10-28 13:29:49 ~5 min android 📦aar
✔️ 6c35178 #2 2024-10-28 13:30:11 ~6 min macos 📦zip
✖️ 6c35178 #2 2024-10-28 13:34:25 ~10 min windows 📦zip
✔️ 6c35178 #2 2024-10-28 13:58:33 ~34 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ a674196 #3 2024-10-28 16:08:00 ~1 min tests 📄log
✔️ a674196 #3 2024-10-28 16:10:36 ~4 min macos 📦zip
✔️ a674196 #3 2024-10-28 16:11:00 ~4 min tests-rpc 📄log
✔️ a674196 #3 2024-10-28 16:12:05 ~5 min linux 📦zip
✔️ a674196 #3 2024-10-28 16:12:09 ~6 min android 📦aar
✔️ a674196 #3 2024-10-28 16:12:22 ~6 min macos 📦zip
✖️ a674196 #3 2024-10-28 16:16:34 ~10 min windows 📦zip
✔️ 255793d #4 2024-10-28 16:13:21 ~2 min tests-rpc 📄log
✔️ 255793d #4 2024-10-28 16:15:09 ~4 min macos 📦zip
✔️ 255793d #4 2024-10-28 16:17:26 ~5 min linux 📦zip
✔️ 255793d #4 2024-10-28 16:18:05 ~5 min android 📦aar
✔️ 255793d #4 2024-10-28 16:18:39 ~6 min macos 📦zip
✖️ 255793d #4 2024-10-28 16:27:09 ~10 min windows 📦zip
✔️ 255793d #4 2024-10-28 16:41:47 ~32 min tests 📄log
✔️ 255793d #5 2024-10-28 18:16:44 ~4 min ios 📦zip

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.47%. Comparing base (097d19a) to head (255793d).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5996   +/-   ##
========================================
  Coverage    47.46%   47.47%           
========================================
  Files          849      849           
  Lines       138611   138611           
========================================
+ Hits         65794    65801    +7     
+ Misses       65017    65012    -5     
+ Partials      7800     7798    -2     
Flag Coverage Δ
functional 10.20% <ø> (-0.04%) ⬇️
unit 46.96% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 29 files with indirect coverage changes

@antdanchenko antdanchenko force-pushed the test-unique-project-per-run branch from 04edb54 to 6c35178 Compare October 28, 2024 13:23
@status-im status-im deleted a comment from github-actions bot Oct 28, 2024
@antdanchenko antdanchenko changed the title tests_: unique project per run test_: unique project per run Oct 28, 2024
@antdanchenko antdanchenko marked this pull request as ready for review October 28, 2024 13:28
@antdanchenko antdanchenko requested review from glitchminer and removed request for 0x31071 October 28, 2024 13:28
_assets/scripts/run_functional_tests.sh Outdated Show resolved Hide resolved
_assets/scripts/run_functional_tests.sh Outdated Show resolved Hide resolved
@igor-sirotin
Copy link
Collaborator

I checked that it fixes #5980

With failing tests
image

The failure is properly reported:
image

@igor-sirotin
Copy link
Collaborator

igor-sirotin commented Oct 28, 2024

There's another issue that we referenc INTEGRATION_TESTS_DOCKER_UID instead of FUNCTIONAL_TESTS_DOCKER_UID here:

user: ${INTEGRATION_TESTS_DOCKER_UID}

Which leads to running status-backend container with root rights.
image

This has to be fixed, but can be done separately.

@antdanchenko antdanchenko force-pushed the test-unique-project-per-run branch from a674196 to 255793d Compare October 28, 2024 16:08
@status-im status-im deleted a comment from github-actions bot Oct 28, 2024
@antdanchenko antdanchenko merged commit 90a0f9d into develop Oct 29, 2024
19 of 21 checks passed
@antdanchenko antdanchenko deleted the test-unique-project-per-run branch October 29, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Functional tests running on develop branch don't report failure
4 participants