Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional tests running on develop branch don't report failure #5980

Closed
igor-sirotin opened this issue Oct 23, 2024 · 3 comments · Fixed by #5996
Closed

Functional tests running on develop branch don't report failure #5980

igor-sirotin opened this issue Oct 23, 2024 · 3 comments · Fixed by #5996

Comments

@igor-sirotin
Copy link
Collaborator

igor-sirotin commented Oct 23, 2024

Here's a PR job, properly failing: https://ci.status.im/blue/organizations/jenkins/status-go%2Fprs%2Ftests-rpc/detail/PR-5969/15/pipeline/

Image

And here is the job for develop branch getting same error, but passing:

https://ci.status.im/blue/organizations/jenkins/status-go%2Ftests-rpc-develop/detail/tests-rpc-develop/7/pipeline/

Image


So it looks like all jobs are passing. But in fact all of them have failed 🙁

Image

@igor-sirotin
Copy link
Collaborator Author

igor-sirotin commented Oct 23, 2024

The issues that lead to failure are fixed here:

@yakimant
Copy link
Member

I would make a branch from failing commit, add sebug to the _assets/scripts/run_functional_tests.sh.

This was referenced Oct 23, 2024
@igor-sirotin
Copy link
Collaborator Author

Actually, the error .../bindata.go": no such file or directory is coming from the go tool covdata command. That's why it doesn't affect the final exit code. Not sure if it should.
The actual bug of not generating files was fixed here: #5979

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants