-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix syncing blocked
contacts
#3799
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (58)
|
|
igor-sirotin
force-pushed
the
fix/sync-blocked-contacts
branch
10 times, most recently
from
July 31, 2023 13:49
0a3175a
to
4b57d22
Compare
MishkaRogachev
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
igor-sirotin
force-pushed
the
fix/sync-blocked-contacts
branch
from
July 31, 2023 16:00
4b57d22
to
a8f2142
Compare
Samyoul
reviewed
Aug 3, 2023
Samyoul
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Thank you for doing this work 🙏
Full test ready
igor-sirotin
force-pushed
the
fix/sync-blocked-contacts
branch
from
August 3, 2023 15:57
8aba9b7
to
4e58c37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3804
Required for status-im/status-desktop#11523
blocked
stateAlice removed you as contact
when unblockingRelated bugs:
Though the test will currently pass, there's a bunch of
fixme
/warning
to be updated when the bugs above fixed.