Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When unblocked, we show 'Alice removed you as contact' #3804

Closed
igor-sirotin opened this issue Jul 25, 2023 · 1 comment · Fixed by #3799
Closed

When unblocked, we show 'Alice removed you as contact' #3804

igor-sirotin opened this issue Jul 25, 2023 · 1 comment · Fixed by #3799
Assignees
@igor-sirotin
Labels
E:Desktop Messenger Syncing Issues about syncing Messenger data when recovering an account

Comments

@igor-sirotin
Copy link
Collaborator

Problem

After Bob's unblocked by Alice, he gets a @Alice removed you as contact system message in response, just as he was blocked.

Reproducible in tests: #3799

Acceptance Criteria

Not sure if we should generate any system message here at all.
But there definitely shouldn't be such message.
@igor-sirotin igor-sirotin added the E:Desktop Messenger Syncing Issues about syncing Messenger data when recovering an account label Jul 25, 2023
@igor-sirotin igor-sirotin mentioned this issue Jul 25, 2023
Merged
@igor-sirotin
Copy link
Collaborator Author

Check why handleRetractContactRequest->prepareMutualStateUpdateMessage is called during unblocking only when there are paired devices.

@github-project-automation github-project-automation bot moved this from Code review to Done in Status Desktop/Mobile Board Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@igor-sirotin igor-sirotin

Labels
E:Desktop Messenger Syncing Issues about syncing Messenger data when recovering an account
Projects
Status Desktop/Mobile Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix syncing blocked contacts status-im/status-go
2 participants
@MishkaRogachev @igor-sirotin